Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem

2015-07-30 Thread Kees Cook
On Thu, Jul 30, 2015 at 12:52 PM, Rasmus Villemoes wrote: > On Fri, Jul 24 2015, Kees Cook wrote: > >> The esc argument is used to reduce which characters will be escaped. >> For example, using " " with ESCAPE_SPACE will not produce any escaped >> spaces. >> > > Yeah, I've been confused by this m

Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem

2015-07-30 Thread Rasmus Villemoes
On Fri, Jul 24 2015, Kees Cook wrote: > The esc argument is used to reduce which characters will be escaped. > For example, using " " with ESCAPE_SPACE will not produce any escaped > spaces. > Yeah, I've been confused by this more than once - the old description and the parameter name suggest th