Re: [PATCH] lib/ida: Document locking requirements a bit better v2

2016-10-27 Thread Tejun Heo
On Thu, Oct 27, 2016 at 09:22:16AM +0200, Daniel Vetter wrote: > I wanted to wrap a bunch of ida_simple_get calls into their own > locking, until I dug around and read the original commit message. > Stuff like this should imo be added to the kernel doc, let's do that. > > v2: Improve the kerneldoc

Re: [PATCH] lib/ida: Document locking requirements a bit better

2016-10-27 Thread Daniel Vetter
On Wed, Oct 26, 2016 at 04:07:25PM -0400, Tejun Heo wrote: > Hello, Daniel. > > On Wed, Oct 26, 2016 at 09:25:25PM +0200, Daniel Vetter wrote: > > > > + * Note that callers must ensure that concurrent access to @ida is not > > > > possible. > > > > + * When simplicity trumps concurrency needs loo

Re: [PATCH] lib/ida: Document locking requirements a bit better

2016-10-26 Thread Tejun Heo
Hello, Daniel. On Wed, Oct 26, 2016 at 09:25:25PM +0200, Daniel Vetter wrote: > > > + * Note that callers must ensure that concurrent access to @ida is not > > > possible. > > > + * When simplicity trumps concurrency needs look at ida_simple_get() > > > instead. > > > > Maybe we can make it a b

Re: [PATCH] lib/ida: Document locking requirements a bit better

2016-10-26 Thread Daniel Vetter
On Wed, Oct 26, 2016 at 10:39:29AM -0400, Tejun Heo wrote: > Hello, Daniel. > > On Wed, Oct 26, 2016 at 04:27:39PM +0200, Daniel Vetter wrote: > > I wanted to wrap a bunch of ida_simple_get calls into their own > > locking, until I dug around and read the original commit message. > > Stuff like th

Re: [PATCH] lib/ida: Document locking requirements a bit better

2016-10-26 Thread Tejun Heo
Hello, Daniel. On Wed, Oct 26, 2016 at 04:27:39PM +0200, Daniel Vetter wrote: > I wanted to wrap a bunch of ida_simple_get calls into their own > locking, until I dug around and read the original commit message. > Stuff like this should imo be added to the kernel doc, let's do that. Generally agr