Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr

2019-04-02 Thread Jacek Anaszewski
Hi Colin, Thank you for the patch. On 3/30/19 9:37 PM, Colin King wrote: From: Colin Ian King Currently data->i2c_addr is being assigned twice, first with the value 0x09 and then immediately afterwards with the value 0x08. The first assignment is redundant and can be removed. Signed-off-by:

Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr

2019-03-31 Thread Pavel Machek
On Sat 2019-03-30 20:37:57, Colin King wrote: > From: Colin Ian King > > Currently data->i2c_addr is being assigned twice, first with the > value 0x09 and then immediately afterwards with the value 0x08. > The first assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King

Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr

2019-03-31 Thread Mukesh Ojha
On 3/31/2019 2:07 AM, Colin King wrote: From: Colin Ian King Currently data->i2c_addr is being assigned twice, first with the value 0x09 and then immediately afterwards with the value 0x08. The first assignment is redundant and can be removed. Signed-off-by: Colin Ian King Reviewed-by: Mukes