Re: [PATCH] leds: Add DT support for leds-pca9532

2014-09-10 Thread Roland Stigge
On 09/09/2014 08:08 PM, Arnd Bergmann wrote: > Is this a full PWM controller? If it is, it would be better to also > provide a #pwm-cells property and register the device with the PWM > subsystem to allow arbitrary users. > > If the PWM is only really usable for LED, it's probably enough to > leav

Re: [PATCH] leds: Add DT support for leds-pca9532

2014-09-09 Thread Arnd Bergmann
On Tuesday 09 September 2014 15:28:00 Roland Stigge wrote: > +#ifdef CONFIG_OF > +static struct pca9532_platform_data *pca9532_parse_dt(struct device *dev) > +{ ... > + > static int pca9532_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > @@ -449,6 +489,11 @@ stati