Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe

2015-08-06 Thread Krzysztof Kozlowski
On 07.08.2015 10:31, nick wrote: > > > On 2015-08-06 08:47 PM, Krzysztof Kozlowski wrote: >> 2015-08-06 22:16 GMT+09:00 nick : >>> >>> >>> On 2015-08-06 08:00 AM, Paolo Bonzini wrote: On 06/08/2015 10:06, Marc Zyngier wrote: >> If this structure of function pointers can handle

Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe

2015-08-06 Thread Krzysztof Kozlowski
2015-08-06 22:16 GMT+09:00 nick : > > > On 2015-08-06 08:00 AM, Paolo Bonzini wrote: >> >> >> On 06/08/2015 10:06, Marc Zyngier wrote: If this structure of function pointers can handle function pointers with a return type of void I will be glad to do what you request otherwise this

Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe

2015-08-06 Thread Christoffer Dall
On Thu, Aug 06, 2015 at 02:00:55PM +0200, Paolo Bonzini wrote: > > > On 06/08/2015 10:06, Marc Zyngier wrote: > > > If this structure of function pointers can handle function pointers with > > > a return type of > > > void I will be glad to do what you request otherwise this would require a >

Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe

2015-08-06 Thread Paolo Bonzini
On 06/08/2015 10:06, Marc Zyngier wrote: > > If this structure of function pointers can handle function pointers with a > > return type of > > void I will be glad to do what you request otherwise this would require a > > major rewrite > > of kvm arm subsystem for a very simple bug fix. > > Ju

Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe

2015-08-06 Thread Marc Zyngier
On 05/08/15 18:07, nick wrote: > > > On 2015-08-05 12:59 PM, Paolo Bonzini wrote: >> >> >> On 05/08/2015 18:48, Nicholas Krause wrote: >>> This fixes the error handling in the function vgic_v3_probe >>> for when calling the function kvm_register_device_ops to check >>> if the call to this functio

Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe

2015-08-05 Thread Paolo Bonzini
On 05/08/2015 18:48, Nicholas Krause wrote: > This fixes the error handling in the function vgic_v3_probe > for when calling the function kvm_register_device_ops to check > if the call to this function has returned a error code and if > so jump to the label out with goto to cleanup no longer requ