Re: [PATCH] knav_qmss_queue: fix a missing-check bug in knav_pool_create()

On 6/11/19 3:08 AM, Gen Zhang wrote: On Tue, Jun 11, 2019 at 10:54:15AM +0100, Marc Zyngier wrote: Hi Gen, No idea why I'm being cc'd on this but hey... ;-) I copied email address ftom thid commit:-) https://github.com/torvalds/linux/commit/832ad0e3da4510fd17f98804abe512ea9a747035#diff-f2a2

Re: [PATCH] knav_qmss_queue: fix a missing-check bug in knav_pool_create()

On Tue, Jun 11, 2019 at 10:54:15AM +0100, Marc Zyngier wrote: > Hi Gen, > > No idea why I'm being cc'd on this but hey... ;-) I copied email address ftom thid commit:-) https://github.com/torvalds/linux/commit/832ad0e3da4510fd17f98804abe512ea9a747035#diff-f2a24befc247191f4b81af93e9336785 > > On 1

Re: [PATCH] knav_qmss_queue: fix a missing-check bug in knav_pool_create()

Hi Gen, No idea why I'm being cc'd on this but hey... ;-) On 11/06/2019 10:37, Gen Zhang wrote: > On Thu, May 30, 2019 at 11:39:49AM +0800, Gen Zhang wrote: >> In knav_pool_create(), 'pool->name' is allocated by kstrndup(). It >> returns NULL when fails. So 'pool->name' should be checked. And fre

Re: [PATCH] knav_qmss_queue: fix a missing-check bug in knav_pool_create()

On Thu, May 30, 2019 at 11:39:49AM +0800, Gen Zhang wrote: > In knav_pool_create(), 'pool->name' is allocated by kstrndup(). It > returns NULL when fails. So 'pool->name' should be checked. And free > 'pool' when error. > > Signed-off-by: Gen Zhang > --- > diff --git a/drivers/soc/ti/knav_qmss_qu