Re: [PATCH] kill an obsolete sub-thread-ptrace stuff

2007-08-03 Thread Roland McGrath
> However, I disagree. exit_notify() doesn't check the ptrace-same-group > case. So, unless I missed something, we set EXIT_DEAD in any case, even > if ptracer doesn't belong to our thread group. Oh, you're right. I was reading the other line you changed. Thanks, Roland - To unsubscribe from th

Re: [PATCH] kill an obsolete sub-thread-ptrace stuff

2007-08-03 Thread Oleg Nesterov
On 08/03, Roland McGrath wrote: > > > There is a couple of subtle checks which were needed to handle ptracing from > > the same thread group. This was deprecated a long ago, imho this code just > > complicates the understanding. > > Looks ok to me. Thanks! > > And, the "->parent->signal->flags &

Re: [PATCH] kill an obsolete sub-thread-ptrace stuff

2007-08-03 Thread Roland McGrath
> There is a couple of subtle checks which were needed to handle ptracing from > the same thread group. This was deprecated a long ago, imho this code just > complicates the understanding. Looks ok to me. > And, the "->parent->signal->flags & SIGNAL_GROUP_EXIT" check in exit_notify() > is not rig