Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-23 Thread Dave Young
On 09/23/15 at 10:49am, Baoquan He wrote: > On 09/23/15 at 09:37am, Dave Young wrote: > > > > Hi, Dave. > > > > > > > > How about removing all of the prefix "crashkernel" in kexec_core. Thus > > > > we can be consistent with the output message prefix "kexec". > > > > > > Ping, any comment is appr

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-22 Thread Minfei Huang
On 09/23/15 at 01:26pm, Baoquan He wrote: > On 09/23/15 at 01:14pm, Minfei Huang wrote: > > On 09/23/15 at 10:49am, Baoquan He wrote: > > > This is weird, user really don't need to know each file. I saw you added > > > a new file kexec_internal.h and all three files includes it. Why not doing > > >

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-22 Thread Baoquan He
On 09/23/15 at 01:14pm, Minfei Huang wrote: > On 09/23/15 at 10:49am, Baoquan He wrote: > > This is weird, user really don't need to know each file. I saw you added > > a new file kexec_internal.h and all three files includes it. Why not doing > > it there to make it the same as before? > > The ou

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-22 Thread Minfei Huang
On 09/23/15 at 10:49am, Baoquan He wrote: > On 09/23/15 at 09:37am, Dave Young wrote: > > > > Hi, Dave. > > > > > > > > How about removing all of the prefix "crashkernel" in kexec_core. Thus > > > > we can be consistent with the output message prefix "kexec". > > > > > > Ping, any comment is appr

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-22 Thread Baoquan He
On 09/23/15 at 09:37am, Dave Young wrote: > > > Hi, Dave. > > > > > > How about removing all of the prefix "crashkernel" in kexec_core. Thus > > > we can be consistent with the output message prefix "kexec". > > > > Ping, any comment is appreciate and helpful. > > Remove "crashkernel" sounds not

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-22 Thread Dave Young
On 09/23/15 at 12:07am, Minfei Huang wrote: > On 09/15/15 at 11:08am, Minfei Huang wrote: > > On 09/14/15 at 04:44pm, Dave Young wrote: > > > On 09/14/15 at 03:50pm, Minfei Huang wrote: > > > > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > > > > Minfei Huang writes: > > > > > > > > > > > k

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-22 Thread Minfei Huang
On 09/15/15 at 11:08am, Minfei Huang wrote: > On 09/14/15 at 04:44pm, Dave Young wrote: > > On 09/14/15 at 03:50pm, Minfei Huang wrote: > > > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > > > Minfei Huang writes: > > > > > > > > > kexec output message misses the prefix "kexec", when Dave Y

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-14 Thread Minfei Huang
On 09/14/15 at 04:44pm, Dave Young wrote: > On 09/14/15 at 03:50pm, Minfei Huang wrote: > > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > > Minfei Huang writes: > > > > > > > kexec output message misses the prefix "kexec", when Dave Young split > > > > the kexec code. To keep the same form

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-14 Thread Dave Young
On 09/14/15 at 03:50pm, Minfei Huang wrote: > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > Minfei Huang writes: > > > > > kexec output message misses the prefix "kexec", when Dave Young split > > > the kexec code. To keep the same format, add the prefix "kexec" to > > > output message. >

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-14 Thread Minfei Huang
On 09/13/15 at 11:52am, Eric W. Biederman wrote: > Minfei Huang writes: > > > kexec output message misses the prefix "kexec", when Dave Young split > > the kexec code. To keep the same format, add the prefix "kexec" to > > output message. > > What of kexec_core? What of the messages that already

Re: [PATCH] kexec: Add prefix "kexec" to output message

2015-09-13 Thread Eric W. Biederman
Minfei Huang writes: > kexec output message misses the prefix "kexec", when Dave Young split > the kexec code. To keep the same format, add the prefix "kexec" to > output message. What of kexec_core? What of the messages that already have a prefix? Eric > Following is the format of output mess