Re: [PATCH] kbuild: fix if_change and friends to consider argument order

2016-05-05 Thread Masahiro Yamada
Hi David, 2016-05-05 17:08 GMT+09:00 Woodhouse, David : > On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote: >> >> This commit fixes arg-check to compare two strings as a whole. >> $(strip ...) is important because we want to ignore the difference >> that comes from white-spaces. > > Do we

Re: [PATCH] kbuild: fix if_change and friends to consider argument order

2016-05-05 Thread Masahiro Yamada
2016-05-05 23:49 GMT+09:00 Masahiro Yamada : > 2016-05-05 17:08 GMT+09:00 Woodhouse, David : >> On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote: >>> >>> This commit fixes arg-check to compare two strings as a whole. >>> $(strip ...) is important because we want to ignore the difference >>>

Re: [PATCH] kbuild: fix if_change and friends to consider argument order

2016-05-05 Thread Masahiro Yamada
2016-05-05 17:08 GMT+09:00 Woodhouse, David : > On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote: >> >> This commit fixes arg-check to compare two strings as a whole. >> $(strip ...) is important because we want to ignore the difference >> that comes from white-spaces. > > Do we? > > I can

Re: [PATCH] kbuild: fix if_change and friends to consider argument order

2016-05-05 Thread Woodhouse, David
On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote: > > This commit fixes arg-check to compare two strings as a whole. > $(strip ...) is important because we want to ignore the difference > that comes from white-spaces. Do we? I can construct a hypothetical situation in which whitespace di