Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets

2024-04-21 Thread Julian Anastasov
Hello, On Sun, 21 Apr 2024, Ismael Luceno wrote: > On 21/Apr/2024 14:01, Julian Anastasov wrote: > > > I'm guessing what should be the Fixes line, may be?: > > > > Fixes: 90017accff61 ("sctp: Add GSO support") > > This seems like the right one. > > > because SCTP GSO was add

Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets

2024-04-21 Thread Ismael Luceno
On 21/Apr/2024 14:01, Julian Anastasov wrote: <...> > Thanks for the fix, I'll accept this but skb_is_gso_sctp() > has comment for pre-condition: skb_is_gso(skb). Can you send v2 > with it? Thanks; sent! > I'm guessing what should be the Fixes line, may be?: > > Fixes: 90017accff61 (

Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets

2024-04-21 Thread Julian Anastasov
Hello, On Thu, 18 Apr 2024, Ismael Luceno wrote: > It was observed in the wild that pairs of consecutive packets would leave > the IPVS with the same wrong checksum, and the issue only went away when > disabling GSO. > > IPVS needs to avoid computing the SCTP checksum when using GSO. >