Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

2013-09-24 Thread Jingoo Han
On Tuesday, September 24, 2013 9:42 PM, Joerg Roedel wrote: > On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote: > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to manually clear the > > device driver data to NULL. >

Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

2013-09-24 Thread David Brown
On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote: The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/iommu/msm_iommu_dev.c |2 -- W

Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

2013-09-24 Thread 'Joerg Roedel'
On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. Please split that into two patches, one for msm and one for omap so th

Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

2013-08-21 Thread Libo Chen
On 2013/8/22 9:53, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. > > Signed-off-by: Jingoo Han > --- It looks good. Acked-by: Libo Chen > drivers/iommu