Re: [PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users

2020-08-30 Thread Qian Cai
On Sun, Aug 30, 2020 at 05:30:33PM -0700, Darrick J. Wong wrote: > On Sat, Aug 29, 2020 at 09:30:57PM -0400, Qian Cai wrote: > > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by > > unprivileged users which would taint the kernel, or worse - panic if > > panic_on_warn or panic_on_

Re: [PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users

2020-08-30 Thread Darrick J. Wong
On Sat, Aug 29, 2020 at 09:30:57PM -0400, Qian Cai wrote: > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by > unprivileged users which would taint the kernel, or worse - panic if > panic_on_warn or panic_on_taint is set. Hence, just convert it to > pr_warn_ratelimited() to let us