Re: [PATCH] init: fix in-place parameter modification regression

2013-10-20 Thread Rusty Russell
Krzysztof Mazur writes: > On Fri, Oct 18, 2013 at 02:20:38PM +1030, Rusty Russell wrote: >> Back when there was almost no parameter parsing support, everyone got >> used to keeping pointers into the original. Making everyone kstrdup() >> seems like gratuitous churn which is likely to make more bu

Re: [PATCH] init: fix in-place parameter modification regression

2013-10-18 Thread Krzysztof Mazur
On Fri, Oct 18, 2013 at 02:20:38PM +1030, Rusty Russell wrote: > Back when there was almost no parameter parsing support, everyone got > used to keeping pointers into the original. Making everyone kstrdup() > seems like gratuitous churn which is likely to make more bugs. > > Your fix means __setu

Re: [PATCH] init: fix in-place parameter modification regression

2013-10-17 Thread Rusty Russell
Krzysztof Mazur writes: > On Mon, Oct 14, 2013 at 12:34:02PM +0100, Pawel Moll wrote: >> So, assuming that it is actually legal to modify static_command_line in >> __setup()-s (and I must say I have rather mixed feelings about it ;-), > > I also have mixed feelings about that, but the parse_args()

Re: [PATCH] init: fix in-place parameter modification regression

2013-10-14 Thread Pawel Moll
On Mon, 2013-10-14 at 13:50 +0100, Krzysztof Mazur wrote: > > Hold on. static_command_line can be only accessed within init/main.c. As > > far as I can say, it is only used by unknown_bootoption() (so your > > __setup callbacks) and then in the do_initcall_level(). > > But I think it's legal to ke

Re: [PATCH] init: fix in-place parameter modification regression

2013-10-14 Thread Krzysztof Mazur
On Mon, Oct 14, 2013 at 12:34:02PM +0100, Pawel Moll wrote: > On Sat, 2013-10-12 at 19:05 +0100, Krzysztof Mazur wrote: > > Before commit 026cee0086fe1df4cf74691cf273062cc769617d > > ("params: _initcall-like kernel parameters") the __setup > > parameter parsing code could modify parameter in the >

Re: [PATCH] init: fix in-place parameter modification regression

2013-10-14 Thread Pawel Moll
On Sat, 2013-10-12 at 19:05 +0100, Krzysztof Mazur wrote: > Before commit 026cee0086fe1df4cf74691cf273062cc769617d > ("params: _initcall-like kernel parameters") the __setup > parameter parsing code could modify parameter in the > static_command_line buffer and such modifications were kept. After >

Re: [PATCH] init: fix in-place parameter modification regression

2013-10-14 Thread Krzysztof Mazur
On Mon, Oct 14, 2013 at 06:06:23PM +1030, Rusty Russell wrote: > Krzysztof Mazur writes: > > Before commit 026cee0086fe1df4cf74691cf273062cc769617d > > ("params: _initcall-like kernel parameters") the __setup > > parameter parsing code could modify parameter in the > > static_command_line buffer a

Re: [PATCH] init: fix in-place parameter modification regression

2013-10-14 Thread Rusty Russell
Krzysztof Mazur writes: > Before commit 026cee0086fe1df4cf74691cf273062cc769617d > ("params: _initcall-like kernel parameters") the __setup > parameter parsing code could modify parameter in the > static_command_line buffer and such modifications were kept. After > that commit such modifications a