Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-29 Thread Dave Young
On 04/29/14 at 12:21pm, Thomas Gleixner wrote: > On Tue, 29 Apr 2014, Matt Fleming wrote: > > I would just replace the existing calls to early_ioremap() with > > efi_ioremap() and implement it like so (all in > > arch/x86/platform/efi/early_printk.c), > > > > static void *efi_ioremap(resource_size

Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-29 Thread Thomas Gleixner
On Tue, 29 Apr 2014, Matt Fleming wrote: > I would just replace the existing calls to early_ioremap() with > efi_ioremap() and implement it like so (all in > arch/x86/platform/efi/early_printk.c), > > static void *efi_ioremap(resource_size_t phys_addr, unsigned long size) > { > if (system_st

Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-29 Thread Dave Young
On 04/29/14 at 10:45am, Matt Fleming wrote: > On Sat, 26 Apr, at 03:28:21PM, Dave Young wrote: > > > > There's other kernel messages without appending ,keep. > > > > Also console=ttyS0 does not work with earlyprintk=efi,keep, removing > > ,keep it works well. > > Try console=efi With console=ef

Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-29 Thread Matt Fleming
On Sat, 26 Apr, at 03:28:21PM, Dave Young wrote: > > There's other kernel messages without appending ,keep. > > Also console=ttyS0 does not work with earlyprintk=efi,keep, removing > ,keep it works well. Try console=efi > > > Actually efi earlyprintk is using __init functions such as early_iore

Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-26 Thread Dave Young
On 04/25/14 at 12:53pm, Matt Fleming wrote: > On Thu, 24 Apr, at 05:36:58PM, Dave Young wrote: > > earlyprint=efi,keep results a kernel hang after "Freeing unused kernel > > memory" > > Are you sure it hangs and it's not just that nothing is output to the > console after that point? There's oth

Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-25 Thread Matt Fleming
On Thu, 24 Apr, at 05:36:58PM, Dave Young wrote: > earlyprint=efi,keep results a kernel hang after "Freeing unused kernel memory" Are you sure it hangs and it's not just that nothing is output to the console after that point? > Actually efi earlyprintk is using __init functions such as early_ior

Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-24 Thread Dave Young
On 04/24/14 at 12:45pm, Ingo Molnar wrote: > > * Dave Young wrote: > > > earlyprint=efi,keep results a kernel hang after "Freeing unused kernel > > memory" > > That's a bug. > > > > > Actually efi earlyprintk is using __init functions such as early_ioremap > > etc. > > Thus efi earlyconsole

Re: [PATCH] ignore ,keep for efi earlyprintk

2014-04-24 Thread Ingo Molnar
* Dave Young wrote: > earlyprint=efi,keep results a kernel hang after "Freeing unused kernel memory" That's a bug. > > Actually efi earlyprintk is using __init functions such as early_ioremap etc. > Thus efi earlyconsole can not be kept. > > So just ignore it and give out a warning to user.