RE: [PATCH] i386 add idle notifier (take 2)

2006-12-11 Thread Pallipadi, Venkatesh
ger.kernel.org >Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; Stephane Eranian >Subject: Re: [PATCH] i386 add idle notifier (take 2) > >Hello, > >[This is the second take due to stray '}' in the patch. Sorry >about that] > >Here is a patch that adds an idle notifi

Re: [PATCH] i386 add idle notifier

2006-11-30 Thread Stephane Eranian
Hi, On Thu, Nov 30, 2006 at 12:21:41AM +0100, Andi Kleen wrote: > > > An alternative approach might be to change perfmon so that it works out > > whether it is being called by an idle thread > > > > if ((current->flags & PF_IDLE) && (other stuff to do with irqs?)) > > return; >

Re: [PATCH] i386 add idle notifier

2006-11-29 Thread Andi Kleen
> An alternative approach might be to change perfmon so that it works out > whether it is being called by an idle thread > > if ((current->flags & PF_IDLE) && (other stuff to do with irqs?)) > return; The problem is that the performance counters just keep running in the CPU.

Re: [PATCH] i386 add idle notifier

2006-11-29 Thread Russell King
On Wed, Nov 29, 2006 at 03:05:44PM -0800, Andrew Morton wrote: > btw, I don't think anyone promised that __test_and_set_bit is atomic wrt > interrupts on all architectures. Is OK for x86. Correct. The generic version found in include/asm-generic/bitops/non-atomic.h is not interrupt safe: /** *

Re: [PATCH] i386 add idle notifier

2006-11-29 Thread Andrew Morton
On Wed, 29 Nov 2006 14:18:53 -0800 Stephane Eranian <[EMAIL PROTECTED]> wrote: > Hello, > > On Wed, Nov 29, 2006 at 01:09:44PM -0800, Andrew Morton wrote: > > On Wed, 29 Nov 2006 17:09:39 + > > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > On Wed, Nov 29, 2006 at 08:25:40AM -0800, S

Re: [PATCH] i386 add idle notifier

2006-11-29 Thread Stephane Eranian
Hello, On Wed, Nov 29, 2006 at 01:09:44PM -0800, Andrew Morton wrote: > On Wed, 29 Nov 2006 17:09:39 + > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > On Wed, Nov 29, 2006 at 08:25:40AM -0800, Stephane Eranian wrote: > > > Hello, > > > > > > Here is a patch that adds an idle notifier to

Re: [PATCH] i386 add idle notifier

2006-11-29 Thread Andrew Morton
On Wed, 29 Nov 2006 17:09:39 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Wed, Nov 29, 2006 at 08:25:40AM -0800, Stephane Eranian wrote: > > Hello, > > > > Here is a patch that adds an idle notifier to the i386 tree. > > The idle notifier functionalities and implementation are > > iden

Re: [PATCH] i386 add idle notifier

2006-11-29 Thread Christoph Hellwig
On Wed, Nov 29, 2006 at 08:25:40AM -0800, Stephane Eranian wrote: > Hello, > > Here is a patch that adds an idle notifier to the i386 tree. > The idle notifier functionalities and implementation are > identical to the x86_64 idle notifier. We use the idle notifier > in the context of perfmon. > >

Re: [PATCH] i386 add idle notifier (take 2)

2006-11-29 Thread Stephane Eranian
Hello, [This is the second take due to stray '}' in the patch. Sorry about that] Here is a patch that adds an idle notifier to the i386 tree. The idle notifier functionalities and implementation are identical to the x86_64 idle notifier. We use the idle notifier in the context of perfmon. The pa

Re: [PATCH] i386 add idle notifier

2006-11-29 Thread Andi Kleen
On Wednesday 29 November 2006 17:25, Stephane Eranian wrote: > Hello, > > Here is a patch that adds an idle notifier to the i386 tree. > The idle notifier functionalities and implementation are > identical to the x86_64 idle notifier. We use the idle notifier > in the context of perfmon. > > The