Re: [PATCH] i2c-gpio: Add support for new-style clients

2007-06-15 Thread Jean Delvare
On Thu, 14 Jun 2007 15:40:46 +0900 (JST), Atsushi Nemoto wrote: > On Thu, 14 Jun 2007 08:24:17 +0200, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > + if (pdev->id == -1) > > > + ret = i2c_bit_add_bus(adap); > > > + else > > > + ret = i2c_bit_add_numbered_bus(adap); > > > if (ret)

Re: [PATCH] i2c-gpio: Add support for new-style clients

2007-06-13 Thread Atsushi Nemoto
On Thu, 14 Jun 2007 08:24:17 +0200, Jean Delvare <[EMAIL PROTECTED]> wrote: > > + if (pdev->id == -1) > > + ret = i2c_bit_add_bus(adap); > > + else > > + ret = i2c_bit_add_numbered_bus(adap); > > if (ret) > > goto err_add_bus; > > > > This isn't sufficient

Re: [PATCH] i2c-gpio: Add support for new-style clients

2007-06-13 Thread Jean Delvare
Hi Atsushi, On Wed, 13 Jun 2007 00:43:16 +0900 (JST), Atsushi Nemoto wrote: > Use i2c_bit_add_numbered_bus() if device id specified, so that the > i2c-gpio adapter works well with new-style pre-declared devices. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> > --- > diff --git a/drivers/i2

Re: [PATCH] i2c-gpio: Add support for new-style clients

2007-06-13 Thread Haavard Skinnemoen
On Wed, 13 Jun 2007 00:43:16 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > Use i2c_bit_add_numbered_bus() if device id specified, so that the > i2c-gpio adapter works well with new-style pre-declared devices. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> Makes sense to me. I ha