Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-13 Thread Michal Hocko
On Mon 12-08-19 11:33:26, Sasha Levin wrote: [...] > I'd be happy to run whatever validation/regression suite for mm/ you > would suggest. You would have to develop one first and I am afraid that won't be really simple and useful. > I've heard the "every patch is a snowflake" story quite a few ti

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-12 Thread Andrew Morton
On Mon, 12 Aug 2019 11:33:26 -0400 Sasha Levin wrote: > >I thought that absence of the Cc is the indication :P. Anyway, I really > >do not understand why should we bother, really. I have tried to explain > >that stable maintainers should follow Cc: stable because we bother to > >consider that par

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-12 Thread Qian Cai
On Mon, 2019-08-12 at 11:33 -0400, Sasha Levin wrote: > On Mon, Aug 12, 2019 at 03:22:26PM +0200, Michal Hocko wrote: > > On Mon 12-08-19 15:14:12, Vlastimil Babka wrote: > > > On 8/12/19 10:45 AM, Michal Hocko wrote: > > > > On Sun 11-08-19 19:46:14, Sasha Levin wrote: > > > > > On Fri, Aug 09, 20

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-12 Thread Sasha Levin
On Mon, Aug 12, 2019 at 03:22:26PM +0200, Michal Hocko wrote: On Mon 12-08-19 15:14:12, Vlastimil Babka wrote: On 8/12/19 10:45 AM, Michal Hocko wrote: > On Sun 11-08-19 19:46:14, Sasha Levin wrote: >> On Fri, Aug 09, 2019 at 03:17:18PM -0700, Andrew Morton wrote: >>> On Fri, 9 Aug 2019 08:46:33

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-12 Thread Michal Hocko
On Mon 12-08-19 15:14:12, Vlastimil Babka wrote: > On 8/12/19 10:45 AM, Michal Hocko wrote: > > On Sun 11-08-19 19:46:14, Sasha Levin wrote: > >> On Fri, Aug 09, 2019 at 03:17:18PM -0700, Andrew Morton wrote: > >>> On Fri, 9 Aug 2019 08:46:33 +0200 Michal Hocko wrote: > >>> > >>> It should work if

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-12 Thread Vlastimil Babka
On 8/12/19 10:45 AM, Michal Hocko wrote: > On Sun 11-08-19 19:46:14, Sasha Levin wrote: >> On Fri, Aug 09, 2019 at 03:17:18PM -0700, Andrew Morton wrote: >>> On Fri, 9 Aug 2019 08:46:33 +0200 Michal Hocko wrote: >>> >>> It should work if we ask stable trees maintainers not to backport >>> such pat

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-12 Thread Michal Hocko
On Sun 11-08-19 19:46:14, Sasha Levin wrote: > On Fri, Aug 09, 2019 at 03:17:18PM -0700, Andrew Morton wrote: > > On Fri, 9 Aug 2019 08:46:33 +0200 Michal Hocko wrote: > > > > > > Maybe we should introduce the Fixes-no-stable: tag. That should get > > > > their attention. > > > > > > No please,

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-11 Thread Sasha Levin
On Fri, Aug 09, 2019 at 03:17:18PM -0700, Andrew Morton wrote: On Fri, 9 Aug 2019 08:46:33 +0200 Michal Hocko wrote: > Maybe we should introduce the Fixes-no-stable: tag. That should get > their attention. No please, Fixes shouldn't be really tight to any stable tree rules. It is a very usef

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-09 Thread Andrew Morton
On Fri, 9 Aug 2019 08:46:33 +0200 Michal Hocko wrote: > > Maybe we should introduce the Fixes-no-stable: tag. That should get > > their attention. > > No please, Fixes shouldn't be really tight to any stable tree rules. It > is a very useful indication of which commit has introduced bug/problem

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-08 Thread Michal Hocko
On Thu 08-08-19 16:39:28, Andrew Morton wrote: > On Thu, 8 Aug 2019 20:53:13 +0200 Michal Hocko wrote: > > > > https://lkml.org/lkml/2019/6/1/165 > > > > > > Ironic to find that commit message in a stable backport. > > > > > > I'm happy to drop the Fixes tag. > > > > No, please do not drop the

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-08 Thread Andrew Morton
On Thu, 8 Aug 2019 20:53:13 +0200 Michal Hocko wrote: > > https://lkml.org/lkml/2019/6/1/165 > > > > Ironic to find that commit message in a stable backport. > > > > I'm happy to drop the Fixes tag. > > No, please do not drop the Fixes tag. That is a very _useful_ > information. If the stable

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-08 Thread Michal Hocko
On Thu 08-08-19 09:55:45, Mike Kravetz wrote: > On 8/8/19 12:47 AM, Michal Hocko wrote: > > On Thu 08-08-19 09:46:07, Michal Hocko wrote: > >> On Wed 07-08-19 17:05:33, Mike Kravetz wrote: > >>> Li Wang discovered that LTP/move_page12 V2 sometimes triggers SIGBUS > >>> in the kernel-v5.2.3 testing.

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-08 Thread Mike Kravetz
On 8/8/19 12:47 AM, Michal Hocko wrote: > On Thu 08-08-19 09:46:07, Michal Hocko wrote: >> On Wed 07-08-19 17:05:33, Mike Kravetz wrote: >>> Li Wang discovered that LTP/move_page12 V2 sometimes triggers SIGBUS >>> in the kernel-v5.2.3 testing. This is caused by a race between hugetlb >>> page migr

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-08 Thread Michal Hocko
On Thu 08-08-19 09:46:07, Michal Hocko wrote: > On Wed 07-08-19 17:05:33, Mike Kravetz wrote: > > Li Wang discovered that LTP/move_page12 V2 sometimes triggers SIGBUS > > in the kernel-v5.2.3 testing. This is caused by a race between hugetlb > > page migration and page fault. > > > > If a hugetlb

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-08 Thread Michal Hocko
On Wed 07-08-19 17:05:33, Mike Kravetz wrote: > Li Wang discovered that LTP/move_page12 V2 sometimes triggers SIGBUS > in the kernel-v5.2.3 testing. This is caused by a race between hugetlb > page migration and page fault. > > If a hugetlb page can not be allocated to satisfy a page fault, the ta

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-07 Thread Naoya Horiguchi
On Wed, Aug 07, 2019 at 05:05:33PM -0700, Mike Kravetz wrote: > Li Wang discovered that LTP/move_page12 V2 sometimes triggers SIGBUS > in the kernel-v5.2.3 testing. This is caused by a race between hugetlb > page migration and page fault. > > If a hugetlb page can not be allocated to satisfy a pa

Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS

2019-08-07 Thread Mike Kravetz
On 8/7/19 7:24 PM, 裘稀石(稀石) wrote: > Hi Mike, > > Do you mean the similar race is like the following? > > migration clearing the pte > page fault(before we return error, and now we return 0, then try page fault > again, right?) > migration writing a migration entry Yes, something like the