Re: [PATCH] gpio: mcp23s08: Trivial: Fixed coding style issues

2014-03-14 Thread Linus Walleij
On Wed, Mar 12, 2014 at 9:16 PM, Gerhard Sittig wrote: > 'sizeof' is an operator, very much like a unary minus or > unary ampersand which neither require parentheses. So either of > "sizeof(x)" as well as "sizeof x" are legal with regard to the C > language. It's just that the community prefer

Re: [PATCH] gpio: mcp23s08: Trivial: Fixed coding style issues

2014-03-12 Thread Gerhard Sittig
On Wed, Mar 12, 2014 at 14:53 +0100, Linus Walleij wrote: > > On Fri, Mar 7, 2014 at 12:25 AM, Gary Servin wrote: > > > This coding style issue was detected using the checkpatch.pl script > > > > Signed-off-by: Gary Servin > > Sometimes the compiler is just too forgiving :-/ > Thanks a lot for

Re: [PATCH] gpio: mcp23s08: Trivial: Fixed coding style issues

2014-03-12 Thread Linus Walleij
On Fri, Mar 7, 2014 at 12:25 AM, Gary Servin wrote: > This coding style issue was detected using the checkpatch.pl script > > Signed-off-by: Gary Servin Sometimes the compiler is just too forgiving :-/ Thanks a lot for fixing this, patch applied. Yours, Linus Walleij -- To unsubscribe from thi

Re: [PATCH] gpio: mcp23s08: Trivial: Fixed coding style issues

2014-03-06 Thread Alexandre Courbot
On Fri, Mar 7, 2014 at 8:25 AM, Gary Servin wrote: > This coding style issue was detected using the checkpatch.pl script Phew. These ones were bad. Reviewed-by: Alexandre Courbot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge