Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-27 Thread Linus Walleij
On Sat, May 17, 2014 at 4:37 PM, Alexandre Courbot wrote: > On Thu, May 15, 2014 at 12:44 AM, Zhu, Lejun > wrote: >> +static void __crystalcove_irq_type(int gpio, int type) >> +{ >> + u8 ctli = gpio < 8 ? GPIO0P0CTLI + gpio : GPIO1P0CTLI + (gpio - 8); > > Not a big comment, but wouldn't i

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-20 Thread Zhu, Lejun
On 5/19/2014 10:13 PM, Mathias Nyman wrote: > On 05/19/2014 03:27 AM, Zhu, Lejun wrote: >> >> >> On 5/17/2014 1:33 AM, Linus Walleij wrote: >>> On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun >>> wrote: >>> Devices based on Intel SoC products such as Baytrail have a Power Management IC. I

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-20 Thread Zhu, Lejun
On 5/20/2014 4:30 PM, Mika Westerberg wrote: > On Mon, May 19, 2014 at 01:39:33PM +0300, Mika Westerberg wrote: >> On Wed, May 14, 2014 at 11:44:07PM +0800, Zhu, Lejun wrote: >>> Devices based on Intel SoC products such as Baytrail have a Power >>> Management IC. In the PMIC there are subsystems

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-20 Thread Mika Westerberg
On Mon, May 19, 2014 at 01:39:33PM +0300, Mika Westerberg wrote: > On Wed, May 14, 2014 at 11:44:07PM +0800, Zhu, Lejun wrote: > > Devices based on Intel SoC products such as Baytrail have a Power > > Management IC. In the PMIC there are subsystems for voltage regulation, > > A/D conversion, GPIO a

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-19 Thread Mathias Nyman
On 05/19/2014 03:27 AM, Zhu, Lejun wrote: > > > On 5/17/2014 1:33 AM, Linus Walleij wrote: >> On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun >> wrote: >> >>> Devices based on Intel SoC products such as Baytrail have a Power >>> Management IC. In the PMIC there are subsystems for voltage regulation

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-19 Thread Mika Westerberg
On Wed, May 14, 2014 at 11:44:07PM +0800, Zhu, Lejun wrote: > Devices based on Intel SoC products such as Baytrail have a Power > Management IC. In the PMIC there are subsystems for voltage regulation, > A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called > Crystal Cove. > > T

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-18 Thread Zhu, Lejun
On 5/17/2014 10:37 PM, Alexandre Courbot wrote: > On Thu, May 15, 2014 at 12:44 AM, Zhu, Lejun > wrote: >> Devices based on Intel SoC products such as Baytrail have a Power >> Management IC. In the PMIC there are subsystems for voltage regulation, >> A/D conversion, GPIO and PWMs. The PMIC in B

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-18 Thread Zhu, Lejun
On 5/17/2014 1:33 AM, Linus Walleij wrote: > On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun wrote: > >> Devices based on Intel SoC products such as Baytrail have a Power >> Management IC. In the PMIC there are subsystems for voltage regulation, >> A/D conversion, GPIO and PWMs. The PMIC in Baytrai

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-17 Thread Alexandre Courbot
On Thu, May 15, 2014 at 12:44 AM, Zhu, Lejun wrote: > Devices based on Intel SoC products such as Baytrail have a Power > Management IC. In the PMIC there are subsystems for voltage regulation, > A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called > Crystal Cove. > > This patc

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-16 Thread Linus Walleij
On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun wrote: > Devices based on Intel SoC products such as Baytrail have a Power > Management IC. In the PMIC there are subsystems for voltage regulation, > A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called > Crystal Cove. > > This patc