Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Doug Anderson
Hi, On Thu, Jun 20, 2019 at 1:25 PM Nick Desaulniers wrote: > > On Thu, Jun 20, 2019 at 1:13 PM Doug Anderson wrote: > > On Thu, Jun 20, 2019 at 12:53 PM Nick Desaulniers > > wrote: > > > > > > I do miss Doug's Kbuild caching patches' speedup. > > > > You actually get quite a bit of this by gra

Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Matthias Kaehlcke
On Thu, Jun 20, 2019 at 12:53:22PM -0700, Nick Desaulniers wrote: > On Thu, Jun 20, 2019 at 11:45 AM Matthias Kaehlcke wrote: > > > > gen_compile_command.py currently assumes that the .cmd files and the > > source code live in the same directory, which is not the case when > > a separate KBUILD_OU

Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Matthias Kaehlcke
On Thu, Jun 20, 2019 at 12:23:45PM -0700, Tom Roeder wrote: > I can confirm that I can still run clang-tidy on the kernel using this > new version of the script; it generates a version of > compile_commands.json that works in my case. > > On Thu, Jun 20, 2019 at 11:45:23AM -0700, Matthias Kaehlcke

Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Nathan Chancellor
On Thu, Jun 20, 2019 at 01:25:36PM -0700, Nick Desaulniers wrote: > On Thu, Jun 20, 2019 at 1:13 PM Doug Anderson wrote: > > On Thu, Jun 20, 2019 at 12:53 PM Nick Desaulniers > > wrote: > > > > > > I do miss Doug's Kbuild caching patches' speedup. > > > > You actually get quite a bit of this by g

Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Nick Desaulniers
On Thu, Jun 20, 2019 at 1:13 PM Doug Anderson wrote: > On Thu, Jun 20, 2019 at 12:53 PM Nick Desaulniers > wrote: > > > > I do miss Doug's Kbuild caching patches' speedup. > > You actually get quite a bit of this by grabbing a new version of > ccache (assuming you use ccache). :-P You still hav

Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Doug Anderson
Hi, On Thu, Jun 20, 2019 at 12:53 PM Nick Desaulniers wrote: > > I do miss Doug's Kbuild caching patches' speedup. You actually get quite a bit of this by grabbing a new version of ccache (assuming you use ccache). :-P You still have to pay the penalty (twice) for all the options that are test

Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Nick Desaulniers
On Thu, Jun 20, 2019 at 11:45 AM Matthias Kaehlcke wrote: > > gen_compile_command.py currently assumes that the .cmd files and the > source code live in the same directory, which is not the case when > a separate KBUILD_OUTPUT directory is used. Great point; android builds the kernel outside of t

Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory

2019-06-20 Thread Tom Roeder
I can confirm that I can still run clang-tidy on the kernel using this new version of the script; it generates a version of compile_commands.json that works in my case. On Thu, Jun 20, 2019 at 11:45:23AM -0700, Matthias Kaehlcke wrote: > gen_compile_command.py currently assumes that the .cmd files