Re: [PATCH] fuse: don't check for file->private_data on open().

2014-11-13 Thread Greg Kroah-Hartman
On Thu, Nov 13, 2014 at 12:13:32PM +0100, Martin Kepplinger wrote: > Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi : > >On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger > >wrote: > > > >> In this week's -next this should have changed. My SSD broke down so i > >have to delay further

Re: [PATCH] fuse: don't check for file->private_data on open().

2014-11-13 Thread Martin Kepplinger
Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi : >On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger >wrote: > >> In this week's -next this should have changed. My SSD broke down so i >have to delay further work for a few days, i'm sorry. > >Please be more careful with such patches. H

Re: [PATCH] fuse: don't check for file->private_data on open().

2014-11-13 Thread Miklos Szeredi
On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger wrote: > In this week's -next this should have changed. My SSD broke down so i have to > delay further work for a few days, i'm sorry. Please be more careful with such patches. Have you audited all of the (ca. 200) misc drivers? If not, this

Re: [PATCH] fuse: don't check for file->private_data on open().

2014-11-13 Thread Martin Kepplinger
Am 13. November 2014 10:40:38 MEZ, schrieb Miklos Szeredi : >On Wed, Nov 12, 2014 at 5:31 PM, Martin Kepplinger >wrote: >> The miscdevice core now sets file->private_data to the struct >miscdevice >> so don't fail when this is not NULL. > >Does it? Look: > >static int misc_open(struct inode * ino

Re: [PATCH] fuse: don't check for file->private_data on open().

2014-11-13 Thread Miklos Szeredi
On Wed, Nov 12, 2014 at 5:31 PM, Martin Kepplinger wrote: > The miscdevice core now sets file->private_data to the struct miscdevice > so don't fail when this is not NULL. Does it? Look: static int misc_open(struct inode * inode, struct file * file) { ... if (file->f_op->open) {

Re: [PATCH] fuse: don't check for file->private_data on open().

2014-11-12 Thread Giedrius Statkevicius
On 2014.11.12 18:31, Martin Kepplinger wrote: > The miscdevice core now sets file->private_data to the struct miscdevice > so don't fail when this is not NULL. > > Reported-by: Thierry Reding > Signed-off-by: Martin Kepplinger > --- Hello, Looks like this patch does not solve the problem with F

Re: [PATCH] fuse: don't check for file->private_data on open().

2014-11-12 Thread Martin Kepplinger
Am 2014-11-12 um 17:31 schrieb Martin Kepplinger: > The miscdevice core now sets file->private_data to the struct miscdevice > so don't fail when this is not NULL. > > Reported-by: Thierry Reding > Signed-off-by: Martin Kepplinger > --- > This is a question: what does this check provide and does