Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing

2015-11-16 Thread Namhyung Kim
Hi Steve, On Mon, Nov 16, 2015 at 10:54:53AM -0500, Steven Rostedt wrote: > On Sat, 14 Nov 2015 18:32:28 +0900 > Namhyung Kim wrote: > > > The commit f1ab00af816e ("ftrace/x86: Get rid of ftrace_caller_setup") > > moved code that loads ftrace_ops into 3rd parameter but it missed to do > > for st

Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing

2015-11-16 Thread Steven Rostedt
On Mon, 16 Nov 2015 10:54:53 -0500 Steven Rostedt wrote: > This isn't needed, nor will the parameter be used if added. A comment > should probably be added here instead. > > /* > * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not > * set (see include/asm/ftrace.h). Only the

Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing

2015-11-16 Thread Steven Rostedt
On Mon, 16 Nov 2015 10:54:53 -0500 Steven Rostedt wrote: > /* > * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not > * set (see include/asm/ftrace.h). Only the ip and parent ip are used > * and the list function is called when function tracing is enabled. > */ > Namhyung

Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing

2015-11-16 Thread Steven Rostedt
On Sat, 14 Nov 2015 18:32:28 +0900 Namhyung Kim wrote: > The commit f1ab00af816e ("ftrace/x86: Get rid of ftrace_caller_setup") > moved code that loads ftrace_ops into 3rd parameter but it missed to do > for static tracing. > > Signed-off-by: Namhyung Kim > --- > arch/x86/kernel/mcount_64.S |