Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-08 Thread Al Viro
On Fri, Jan 08, 2021 at 09:26:40AM -0700, Jens Axboe wrote: > >> Can you show the callers that DO NOT need it? > > > > OK, so here's my suggestion: > > > > 1) For 5.11, we just re-instate the task_work run in get_signal(). This > >will make TWA_RESUME have the exact same behavior as before. >

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-08 Thread Jens Axboe
On 1/8/21 9:10 AM, Jens Axboe wrote: > On 1/8/21 8:58 AM, Al Viro wrote: >> On Fri, Jan 08, 2021 at 08:13:25AM -0700, Jens Axboe wrote: Anyway, bedtime for me; right now it looks like at least for task == current we always want TWA_SIGNAL. I'll look into that more tomorrow when I ge

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-08 Thread Jens Axboe
On 1/8/21 8:58 AM, Al Viro wrote: > On Fri, Jan 08, 2021 at 08:13:25AM -0700, Jens Axboe wrote: >>> Anyway, bedtime for me; right now it looks like at least for task == >>> current we always want TWA_SIGNAL. I'll look into that more tomorrow >>> when I get up, but so far it smells like switching e

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-08 Thread Al Viro
On Fri, Jan 08, 2021 at 08:13:25AM -0700, Jens Axboe wrote: > > Anyway, bedtime for me; right now it looks like at least for task == > > current we always want TWA_SIGNAL. I'll look into that more tomorrow > > when I get up, but so far it smells like switching everything to > > TWA_SIGNAL would be

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-08 Thread Jens Axboe
On 1/7/21 11:46 PM, Al Viro wrote: > On Fri, Jan 08, 2021 at 05:26:51AM +, Al Viro wrote: >> On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: >>> Song reported a boot regression in a kvm image with 5.11-rc, and bisected >>> it down to the below patch. Debugging this issue, turns out

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Al Viro
On Fri, Jan 08, 2021 at 07:21:52AM +0100, Sedat Dilek wrote: > On Fri, Jan 8, 2021 at 6:30 AM Al Viro wrote: > > > > On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: > > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > > > it down to the below patch. Debuggi

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Al Viro
On Fri, Jan 08, 2021 at 07:21:52AM +0100, Sedat Dilek wrote: > On Fri, Jan 8, 2021 at 6:30 AM Al Viro wrote: > > > > On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: > > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > > > it down to the below patch. Debuggi

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Al Viro
On Fri, Jan 08, 2021 at 05:26:51AM +, Al Viro wrote: > On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > > it down to the below patch. Debugging this issue, turns out that the boot > > stalled when a task

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Sedat Dilek
On Fri, Jan 8, 2021 at 6:30 AM Al Viro wrote: > > On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > > it down to the below patch. Debugging this issue, turns out that the boot > > stalled when a task is waiti

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Sedat Dilek
On Fri, Jan 8, 2021 at 4:56 AM Jens Axboe wrote: > > On 1/7/21 3:17 PM, Doug Anderson wrote: > > Hi, > > > > On Tue, Jan 5, 2021 at 10:30 AM Jens Axboe wrote: > >> > >> Song reported a boot regression in a kvm image with 5.11-rc, and bisected > >> it down to the below patch. Debugging this issue,

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Al Viro
On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > it down to the below patch. Debugging this issue, turns out that the boot > stalled when a task is waiting on a pipe being released. As we no longer > run task_w

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Jens Axboe
On 1/7/21 3:17 PM, Doug Anderson wrote: > Hi, > > On Tue, Jan 5, 2021 at 10:30 AM Jens Axboe wrote: >> >> Song reported a boot regression in a kvm image with 5.11-rc, and bisected >> it down to the below patch. Debugging this issue, turns out that the boot >> stalled when a task is waiting on a p

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Doug Anderson
Hi, On Tue, Jan 5, 2021 at 10:30 AM Jens Axboe wrote: > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > it down to the below patch. Debugging this issue, turns out that the boot > stalled when a task is waiting on a pipe being released. As we no longer > run task_wor