Re: [PATCH] fs/pstore: Perform erase from a worker

2017-03-21 Thread Kees Cook
On Mon, Mar 20, 2017 at 10:58 PM, Namhyung Kim wrote: > Hello, > > On Mon, Mar 20, 2017 at 10:49:16AM -0700, Kees Cook wrote: >> On Fri, Mar 17, 2017 at 2:52 AM, Chris Wilson >> wrote: >> > In order to prevent a cyclic recursion between psi->read_mutex and the >> > inode_lock, we need to move th

Re: [PATCH] fs/pstore: Perform erase from a worker

2017-03-21 Thread Chris Wilson
On Tue, Mar 21, 2017 at 02:58:48PM +0900, Namhyung Kim wrote: > Hello, > > On Mon, Mar 20, 2017 at 10:49:16AM -0700, Kees Cook wrote: > > On Fri, Mar 17, 2017 at 2:52 AM, Chris Wilson > > wrote: > > > In order to prevent a cyclic recursion between psi->read_mutex and the > > > inode_lock, we nee

Re: [PATCH] fs/pstore: Perform erase from a worker

2017-03-20 Thread Namhyung Kim
Hello, On Mon, Mar 20, 2017 at 10:49:16AM -0700, Kees Cook wrote: > On Fri, Mar 17, 2017 at 2:52 AM, Chris Wilson > wrote: > > In order to prevent a cyclic recursion between psi->read_mutex and the > > inode_lock, we need to move the pse->erase to a worker. > > > > [ 605.374955] ===

Re: [PATCH] fs/pstore: Perform erase from a worker

2017-03-20 Thread Kees Cook
On Fri, Mar 17, 2017 at 2:52 AM, Chris Wilson wrote: > In order to prevent a cyclic recursion between psi->read_mutex and the > inode_lock, we need to move the pse->erase to a worker. > > [ 605.374955] == > [ 605.381281] [ INFO: possible circul