Re: [PATCH] fs/buffer.c: Optimize grow_buffer function.

2018-08-07 Thread Sean Fu
On Sat, Jul 21, 2018 at 07:21:16PM +0100, Al Viro wrote: > On Sun, Jul 22, 2018 at 01:30:17AM +0800, Sean Fu wrote: > > Use PAGE_SHIFT and i_blkbits of bd_inode directly to avoid ugly sizebits > > calculation. > > Remove ugly sizebits calculation. > > Remove unnecessary sizebits parameter of grow_d

Re: [PATCH] fs/buffer.c: Optimize grow_buffer function.

2018-07-24 Thread Sean Fu
On Sat, Jul 21, 2018 at 07:21:16PM +0100, Al Viro wrote: > On Sun, Jul 22, 2018 at 01:30:17AM +0800, Sean Fu wrote: > > Use PAGE_SHIFT and i_blkbits of bd_inode directly to avoid ugly sizebits > > calculation. > > Remove ugly sizebits calculation. > > Remove unnecessary sizebits parameter of grow_d

Re: [PATCH] fs/buffer.c: Optimize grow_buffer function.

2018-07-21 Thread Al Viro
On Sun, Jul 22, 2018 at 01:30:17AM +0800, Sean Fu wrote: > Use PAGE_SHIFT and i_blkbits of bd_inode directly to avoid ugly sizebits > calculation. > Remove ugly sizebits calculation. > Remove unnecessary sizebits parameter of grow_dev_page. > > Reduces code size: > > Before: > > sean@linux-zmni: