Re: [PATCH] framebuffer: fix screen corruption when copying

2014-09-30 Thread Tomi Valkeinen
On 16/09/14 19:38, Mikulas Patocka wrote: > The function bitcpy_rev has a bug that may result in screen corruption. > The bug happens under these conditions: > * the end of the destination area of a copy operation is aligned on a long > word boundary > * the end of the source area is not aligned

Re: [PATCH] framebuffer: fix screen corruption when copying

2014-09-17 Thread Mikulas Patocka
On Wed, 17 Sep 2014, Geert Uytterhoeven wrote: > Hi Mikulas, > > On Tue, Sep 16, 2014 at 6:38 PM, Mikulas Patocka wrote: > > The patch also removes the references to fb_memmove in the code that is > > commented out because fb_memmove was removed from framebuffer subsystem. > > I'd leave it as

Re: [PATCH] framebuffer: fix screen corruption when copying

2014-09-16 Thread Geert Uytterhoeven
Hi Mikulas, On Tue, Sep 16, 2014 at 6:38 PM, Mikulas Patocka wrote: > The patch also removes the references to fb_memmove in the code that is > commented out because fb_memmove was removed from framebuffer subsystem. I'd leave it as-is. Using plain memmove() is not correct, as it should operate