Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Jens Axboe
On Wed, Jun 20 2007, Rene Herman wrote: > On 06/20/2007 02:24 PM, Jens Axboe wrote: > > >On Wed, Jun 20 2007, Christoph Hellwig wrote: > >>On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: > > >>> drivers/cdrom/aztcd.c > >>> drivers/cdrom/cm206.c > >>> drivers/cdrom/gscd.c > >>> drive

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Rene Herman
On 06/20/2007 02:24 PM, Jens Axboe wrote: On Wed, Jun 20 2007, Christoph Hellwig wrote: On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: drivers/cdrom/aztcd.c drivers/cdrom/cm206.c drivers/cdrom/gscd.c drivers/cdrom/mcdx.c drivers/cdrom/optcd.c drivers/cdrom/sjcd.c These

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 02:24:09PM +0200, Jens Axboe wrote: > > These are old cdrom drivers that are broken in various ways and probably > > should be killed off aswell. > > I agree (with both sentiments), would anyone mind if I just killed them > off? mitsumi support is being reworked, that can g

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Jens Axboe
On Wed, Jun 20 2007, Christoph Hellwig wrote: > On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: > > Jens Axboe wrote: > > > > > > If you look at most of the code, it's inside ifdef debug statements or > > > comments most of them. So I don't think you can base any removal > > > sugges

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: > Jens Axboe wrote: > > > > If you look at most of the code, it's inside ifdef debug statements or > > comments most of them. So I don't think you can base any removal > > suggestion on that. > > > > The patch itself looks fine though,