Re: [PATCH] filemap.c fixes

2001-05-15 Thread Rik van Riel
On Tue, 15 May 2001, Linus Torvalds wrote: > Can you and Marcelo fight out the changes you've posted and re-do them > against pre2? OK. Though I don't know when Marcelo and I will be on the same timezone again (for some reasons his days don't seem to take 24 hours ;)). > I've applied some of th

Re: [PATCH] filemap.c fixes

2001-05-15 Thread Linus Torvalds
On Tue, 15 May 2001, Rik van Riel wrote: > > > Now, please explain to me why it's not just a simple > > > > SetPageReferenced(page); > > > > and then just moving it lazily from one queue to another.. > ... > Just going with the simple version should work. Can you and Marcelo fight out th

Re: [PATCH] filemap.c fixes

2001-05-15 Thread Rik van Riel
On Mon, 14 May 2001, Linus Torvalds wrote: > > > > + if (PageActive(page)) > > > > + SetPageReferenced(page); > > > > + else > > > > + activate_page(page); > Now, please explain to me why it's not just a simple > > SetPageReferenced(page); > > and

Re: [PATCH] filemap.c fixes

2001-05-14 Thread Linus Torvalds
On Mon, 14 May 2001, Rik van Riel wrote: > On Mon, 14 May 2001, Daniel Phillips wrote: > > > > How about: > > > > > + if (PageActive(page)) > > > + SetPageReferenced(page); > > > + else > > > + activate_page(page); > > Fine with me ... Now, please explain to me why it's not j

Re: [PATCH] filemap.c fixes

2001-05-14 Thread Rik van Riel
On Mon, 14 May 2001, Daniel Phillips wrote: > On Monday 14 May 2001 06:00, Rik van Riel wrote: > > > + if (!PageActive(page)) > > + activate_page(page); > > + else > > + SetPageReferenced(page); > > + > > How about: > > > + if (PageActive(page)) > > + SetPage

Re: [PATCH] filemap.c fixes

2001-05-14 Thread Daniel Phillips
On Monday 14 May 2001 06:00, Rik van Riel wrote: > + if (!PageActive(page)) > + activate_page(page); > + else > + SetPageReferenced(page); > + How about: > + if (PageActive(page)) > + SetPageReferenced(page); > + else > + activate_