Re: [PATCH] f2fs: fix the discard thread sleep timeout under high utilization

2021-03-16 Thread Sahitya Tummala
Hi Chao, Thanks for the review and suggestions. I think the below code should work and cover all the cases we discussed. Let me test it and then put up a new patchset for review. Thanks, Sahitya. Mon, Mar 15, 2021 at 06:31:00PM +0800, Chao Yu wrote: > Hi Sahitya, > > On 2021/3/15 17:45, Sahity

Re: [PATCH] f2fs: fix the discard thread sleep timeout under high utilization

2021-03-15 Thread Chao Yu
Hi Sahitya, On 2021/3/15 17:45, Sahitya Tummala wrote: Hi Chao, On Mon, Mar 15, 2021 at 04:10:22PM +0800, Chao Yu wrote: Hi Sahitya, On 2021/3/15 15:46, Sahitya Tummala wrote: Hi Chao, On Mon, Mar 15, 2021 at 02:12:44PM +0800, Chao Yu wrote: Sahitya, On 2021/3/15 12:56, Sahitya Tummala wr

Re: [PATCH] f2fs: fix the discard thread sleep timeout under high utilization

2021-03-15 Thread Sahitya Tummala
Hi Chao, On Mon, Mar 15, 2021 at 04:10:22PM +0800, Chao Yu wrote: > Hi Sahitya, > > On 2021/3/15 15:46, Sahitya Tummala wrote: > >Hi Chao, > > > >On Mon, Mar 15, 2021 at 02:12:44PM +0800, Chao Yu wrote: > >>Sahitya, > >> > >>On 2021/3/15 12:56, Sahitya Tummala wrote: > >>>When f2fs is heavily uti

Re: [PATCH] f2fs: fix the discard thread sleep timeout under high utilization

2021-03-15 Thread Chao Yu
Hi Sahitya, On 2021/3/15 15:46, Sahitya Tummala wrote: Hi Chao, On Mon, Mar 15, 2021 at 02:12:44PM +0800, Chao Yu wrote: Sahitya, On 2021/3/15 12:56, Sahitya Tummala wrote: When f2fs is heavily utilized over 80%, the current discard policy sets the max sleep timeout of discard thread as 50ms

Re: [PATCH] f2fs: fix the discard thread sleep timeout under high utilization

2021-03-15 Thread Sahitya Tummala
Hi Chao, On Mon, Mar 15, 2021 at 02:12:44PM +0800, Chao Yu wrote: > Sahitya, > > On 2021/3/15 12:56, Sahitya Tummala wrote: > >When f2fs is heavily utilized over 80%, the current discard policy > >sets the max sleep timeout of discard thread as 50ms > >(DEF_MIN_DISCARD_ISSUE_TIME). But this is se

Re: [PATCH] f2fs: fix the discard thread sleep timeout under high utilization

2021-03-14 Thread Chao Yu
Sahitya, On 2021/3/15 12:56, Sahitya Tummala wrote: When f2fs is heavily utilized over 80%, the current discard policy sets the max sleep timeout of discard thread as 50ms (DEF_MIN_DISCARD_ISSUE_TIME). But this is set even when there are no pending discard commands to be issued. This results int