Re: Re: [PATCH] enic: Remove redundant free in enic_set_ringparam

2020-12-24 Thread dinghao . liu
> On Wed, 23 Dec 2020 20:38:33 +0800 Dinghao Liu wrote: > > The error handling paths in enic_alloc_vnic_resources() > > have called enic_free_vnic_resources() before returning. > > So we may not need to call it again on failure at caller > > side. > > > > Signed-off-by: Dinghao Liu > > But it's

Re: [PATCH] enic: Remove redundant free in enic_set_ringparam

2020-12-23 Thread Jakub Kicinski
On Wed, 23 Dec 2020 20:38:33 +0800 Dinghao Liu wrote: > The error handling paths in enic_alloc_vnic_resources() > have called enic_free_vnic_resources() before returning. > So we may not need to call it again on failure at caller > side. > > Signed-off-by: Dinghao Liu But it's harmless, right? S