Re: [PATCH] embarassing typo

2005-03-30 Thread Gene Heskett
On Wednesday 30 March 2005 18:38, John Pearson wrote: >On Wed, Mar 30, 2005 at 12:53:28AM -0500, Gene Heskett wrote > >> On Tuesday 29 March 2005 20:40, Dmitry Torokhov wrote: >> >On Tuesday 29 March 2005 16:58, Michael Tokarev wrote: >> >> Well, it's a matter of readability mostly. ?For now at lea

Re: [PATCH] embarassing typo

2005-03-30 Thread John Pearson
On Wed, Mar 30, 2005 at 12:53:28AM -0500, Gene Heskett wrote > On Tuesday 29 March 2005 20:40, Dmitry Torokhov wrote: > >On Tuesday 29 March 2005 16:58, Michael Tokarev wrote: > >> Well, it's a matter of readability mostly. ?For now at least, when > >> char is always 8 bytes... > > > >Wow, that's o

Re: [PATCH] embarassing typo

2005-03-29 Thread Gene Heskett
On Tuesday 29 March 2005 20:40, Dmitry Torokhov wrote: >On Tuesday 29 March 2005 16:58, Michael Tokarev wrote: >> Well, it's a matter of readability mostly.  For now at least, when >> char is always 8 bytes... > >Wow, that's one huge char you have there ;) Yeah, I was gonna ask what language is so

Re: [PATCH] embarassing typo

2005-03-29 Thread Måns Rullgård
Vicente Feito <[EMAIL PROTECTED]> writes: > On Tuesday 29 March 2005 09:58 pm, you wrote: >> Måns Rullgård wrote: >> > "Ronald S. Bultje" <[EMAIL PROTECTED]> writes: >> >>--- linux-2.6.5/drivers/media/video/zr36050.c.old 16 Sep 2004 22:53:27 >> >> - 1.2 +++ linux-2.6.5/drivers/media/video/zr36

Re: [PATCH] embarassing typo

2005-03-29 Thread Phil Howard
On Wed, Mar 30, 2005 at 04:07:39AM +0200, M?ns Rullg?rd wrote: | Michael Tokarev <[EMAIL PROTECTED]> writes: | | > M?ns Rullg?rd wrote: | >> "Ronald S. Bultje" <[EMAIL PROTECTED]> writes: | >> | >>>--- linux-2.6.5/drivers/media/video/zr36050.c.old 16 Sep 2004 22:53:27 - 1.2 | >>>+++ li

Re: [PATCH] embarassing typo

2005-03-29 Thread Vicente Feito
As long as the variable doesn't get overflowed you would have a negation, you shouldn't do dri_data[5] = ptr->dri * 0xff; if ptr->dri it's 255, but if ptr->dri = 1 i.e. (like is set in zr36050_setup) then you would be getting the negation, -1. the Direct rendering support is a flag afaik, so in thi

Re: [PATCH] embarassing typo

2005-03-29 Thread Måns Rullgård
Michael Tokarev <[EMAIL PROTECTED]> writes: > Måns Rullgård wrote: >> "Ronald S. Bultje" <[EMAIL PROTECTED]> writes: >> >>>--- linux-2.6.5/drivers/media/video/zr36050.c.old16 Sep 2004 22:53:27 >>>- 1.2 >>>+++ linux-2.6.5/drivers/media/video/zr36050.c29 Mar 2005 20:30:23 >>>-

Re: [PATCH] embarassing typo

2005-03-29 Thread Dmitry Torokhov
On Tuesday 29 March 2005 16:58, Michael Tokarev wrote: > Well, it's a matter of readability mostly.  For now at least, when > char is always 8 bytes... Wow, that's one huge char you have there ;) -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] embarassing typo

2005-03-29 Thread Michael Tokarev
Måns Rullgård wrote: "Ronald S. Bultje" <[EMAIL PROTECTED]> writes: --- linux-2.6.5/drivers/media/video/zr36050.c.old 16 Sep 2004 22:53:27 - 1.2 +++ linux-2.6.5/drivers/media/video/zr36050.c 29 Mar 2005 20:30:23 - @@ -419,7 +419,7 @@ dri_data[2] = 0x00; dri_dat

Re: [PATCH] embarassing typo

2005-03-29 Thread Måns Rullgård
"Ronald S. Bultje" <[EMAIL PROTECTED]> writes: > --- linux-2.6.5/drivers/media/video/zr36050.c.old 16 Sep 2004 22:53:27 > - 1.2 > +++ linux-2.6.5/drivers/media/video/zr36050.c 29 Mar 2005 20:30:23 - > @@ -419,7 +419,7 @@ > dri_data[2] = 0x00; > dri_data[3] = 0x04; >