Re: [PATCH] drm: fb helper should avoid sleeping in panic context

2014-12-10 Thread Borislav Petkov
On Tue, Dec 09, 2014 at 08:05:21PM -0500, Rob Clark wrote: > oh, whoops.. gmail hiding quoted text.. > > yeah, that looks sane, > > Reviewed-by: Rob Clark > > On Tue, Dec 9, 2014 at 7:55 PM, rui wang wrote: > > Hi Rob, > > Yes it's exactly what I'm doing. Please scroll down and review my patch

Re: [PATCH] drm: fb helper should avoid sleeping in panic context

2014-12-09 Thread Rob Clark
oh, whoops.. gmail hiding quoted text.. yeah, that looks sane, Reviewed-by: Rob Clark On Tue, Dec 9, 2014 at 7:55 PM, rui wang wrote: > Hi Rob, > Yes it's exactly what I'm doing. Please scroll down and review my patch. > > Thanks > Rui > > On 12/10/14, Rob Clark wrote: >> perhaps fb helpers c

Re: [PATCH] drm: fb helper should avoid sleeping in panic context

2014-12-09 Thread rui wang
Hi Rob, Yes it's exactly what I'm doing. Please scroll down and review my patch. Thanks Rui On 12/10/14, Rob Clark wrote: > perhaps fb helpers could use __drm_modeset_lock_all() w/ trylock=true > in panic context? > > BR, > -R > > On Tue, Dec 9, 2014 at 7:09 PM, rui wang wrote: >> Hi All, >> >>

Re: [PATCH] drm: fb helper should avoid sleeping in panic context

2014-12-09 Thread Rob Clark
perhaps fb helpers could use __drm_modeset_lock_all() w/ trylock=true in panic context? BR, -R On Tue, Dec 9, 2014 at 7:09 PM, rui wang wrote: > Hi All, > > Any comment ? Or any better idea how this should be fixed? > > Regards, > Rui > > -- Forwarded message -- > From: ruiv.w...

Re: [PATCH] drm: fb helper should avoid sleeping in panic context

2014-12-05 Thread rui wang
BTW, the impact of this bug is that the panic cannot reboot the machine and it prints an infinite stream of the error messages. The panic goes on forever because there's a for(;;) loop in __mutex_lock_common(), so we enter __schedule() again and again. Thanks Rui On 12/4/14, ruiv.w...@gmail.com