Re: [PATCH] drivers: block: skd: remove skd_pci_info()

2020-12-13 Thread Damien Le Moal
On Fri, 2020-12-11 at 22:11 +0530, Puranjay Mohan wrote: > PCI core calls __pcie_print_link_status() for every device, it prints > both the link width and the link speed. skd_pci_info() does the same > thing again, hence it can be removed. Hmmm... On my box, I see this for the skd card: [8.50

Re: [PATCH] drivers: block: skd: remove skd_pci_info()

2020-12-11 Thread Chaitanya Kulkarni
On 12/11/20 14:41, Bjorn Helgaas wrote: >> The skd driver prints unknown if the speed is not "2.5GT/s" or "5.0GT/s". >> __pcie_print_link_status() prints "unknown" only if speed >> value >= ARRAY_SIZE(speed_strings). >> >> If a buggy skd card returns value that is not != ("2.5GT/s" or "5.0GT/s") >

Re: [PATCH] drivers: block: skd: remove skd_pci_info()

2020-12-11 Thread Bjorn Helgaas
On Fri, Dec 11, 2020 at 09:50:52PM +, Chaitanya Kulkarni wrote: > On 12/11/20 08:45, Puranjay Mohan wrote: > > PCI core calls __pcie_print_link_status() for every device, it prints > > both the link width and the link speed. skd_pci_info() does the same > > thing again, hence it can be removed.

Re: [PATCH] drivers: block: skd: remove skd_pci_info()

2020-12-11 Thread Chaitanya Kulkarni
On 12/11/20 08:45, Puranjay Mohan wrote: > PCI core calls __pcie_print_link_status() for every device, it prints > both the link width and the link speed. skd_pci_info() does the same > thing again, hence it can be removed. > > Signed-off-by: Puranjay Mohan > --- > drivers/block/skd_main.c | 31 -