Re: [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time()

2014-12-21 Thread Hyogi Gim
On Wed, Dec 17, 2014 at 01:51:50PM -0800, Andrew Morton wrote: > On Wed, 17 Dec 2014 12:15:24 +0900 Hyogi Gim wrote: > > > Add the verification code for returned __rtc_read_time() error in > > rtc_update_irq_enable() and rtc_timer_do_work(). > > > > ... > L > > --- a/drivers/rtc/interface.c > >

Re: [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time()

2014-12-17 Thread Andrew Morton
On Wed, 17 Dec 2014 12:15:24 +0900 Hyogi Gim wrote: > Add the verification code for returned __rtc_read_time() error in > rtc_update_irq_enable() and rtc_timer_do_work(). > > ... L > --- a/drivers/rtc/interface.c > +++ b/drivers/rtc/interface.c > @@ -489,7 +489,10 @@ int rtc_update_irq_enable(st

Re: [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time()

2014-07-30 Thread John Stultz
On Thu, Jul 3, 2014 at 6:22 PM, Hyogi Gim wrote: > In __rtc_set_alarm(), the error after __rtc_read_time() is not checked. > If rtc device fail to read time, we cannot guarantee the following process. > > Add the verification code for returned __rtc_read_time() error. > > Signed-off-by: Hyogi Gim