Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-12 Thread Tilman Schmidt
Am 12.02.2007 19:47 schrieb Greg KH: > +static void gigaset_device_release(struct device *dev) > +{ > + //FIXME anything to do? cf. platform_device_release() > +} > The memory of the platform device itself needs to be freed here, > otherwise, to do it earlier would cause race cond

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-12 Thread Greg KH
On Sun, Feb 04, 2007 at 01:26:48AM +0100, Tilman Schmidt wrote: > Am 03.02.2007 17:09 schrieb Greg KH: > > On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote: > >>> +/* dummy to shut up framework warning */ > >>> +static void gigaset_device_release(struct device *dev) > >>> +{ > >>> + //

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-05 Thread Tilman Schmidt
Andrew Morton schrieb: > On Mon, 05 Feb 2007 02:42:09 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > >> It's a pointer. Are reads and writes of pointer sized objects >> guaranteed to be atomic on every platform? > > Yup - we make the same assumption about longs in various places. > > It's a b

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-04 Thread Andrew Morton
On Mon, 05 Feb 2007 02:42:09 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > Am 04.02.2007 02:56 schrieb Andrew Morton: > > On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > > > +spin_lock_irqsave(&cs->cmdlock, flags); > +cb = cs->cmdbuf; >

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-04 Thread Tilman Schmidt
Am 04.02.2007 02:56 schrieb Andrew Morton: > On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > + spin_lock_irqsave(&cs->cmdlock, flags); + cb = cs->cmdbuf; + spin_unlock_irqrestore(&cs->cmdlock, flags); >>> It is doubtful if the locking here does anyt

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-03 Thread Andrew Morton
On Sun, 04 Feb 2007 02:32:41 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > >> + spin_lock_irqsave(&cs->cmdlock, flags); > >> + cb = cs->cmdbuf; > >> + spin_unlock_irqrestore(&cs->cmdlock, flags); > > > > It is doubtful if the locking here does anything useful. > > It assures atomicity whe

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-03 Thread Tilman Schmidt
Thanks, Andrew, for your review. Some replies: Am 02.02.2007 02:13 schrieb Andrew Morton: > On Thu, 1 Feb 2007 22:12:24 +0100 > Tilman Schmidt <[EMAIL PROTECTED]> wrote: > >> +/* Kbuild sometimes doesn't set this */ >> +#ifndef KBUILD_MODNAME >> +#define KBUILD_MODNAME "asy_gigaset" >> +#endif >

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-03 Thread Tilman Schmidt
Am 03.02.2007 17:09 schrieb Greg KH: > On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote: >>> +/* dummy to shut up framework warning */ >>> +static void gigaset_device_release(struct device *dev) >>> +{ >>> + //FIXME anything to do? cf. platform_device_release() >>> +} >> Ask Greg ;)

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-03 Thread Greg KH
On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote: > > +/* dummy to shut up framework warning */ > > +static void gigaset_device_release(struct device *dev) > > +{ > > + //FIXME anything to do? cf. platform_device_release() > > +} > > Ask Greg ;) Oh come on people. Don't provide an

Re: [PATCH] drivers/isdn/gigaset: new M101 driver

2007-02-01 Thread Andrew Morton
On Thu, 1 Feb 2007 22:12:24 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > +/* Kbuild sometimes doesn't set this */ > +#ifndef KBUILD_MODNAME > +#define KBUILD_MODNAME "asy_gigaset" > +#endif That's a subtle way of reporting a kbuild bug ;) What's the story here? > --- linux-2.6.20-rc6-mm3-o