Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

2014-05-12 Thread Guenter Roeck
On Mon, May 12, 2014 at 06:48:06PM +0200, Jean Delvare wrote: > Hi Guenter, > > On Mon, 12 May 2014 08:59:31 -0700, Guenter Roeck wrote: > > I only see the adt7462 driver scanning for 0x5c. Guess I'll accept the > > address for now; I don't see a good reason not to. > > sensors-detect also scans

Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

2014-05-12 Thread Jean Delvare
Hi Guenter, On Mon, 12 May 2014 08:59:31 -0700, Guenter Roeck wrote: > I only see the adt7462 driver scanning for 0x5c. Guess I'll accept the > address for now; I don't see a good reason not to. sensors-detect also scans it for the SMSC EMC1072, EMC1073 and EMC1074 which we don't support yet. I h

Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

2014-05-12 Thread Guenter Roeck
On Mon, May 12, 2014 at 08:10:51AM +0200, Jean Delvare wrote: > Hi Guenter, Josef, > > On Sun, 11 May 2014 15:40:21 -0700, Guenter Roeck wrote: > > On 05/11/2014 06:00 AM, Josef Gajdusek wrote: > > > @@ -366,14 +433,19 @@ static int emc1403_probe(struct i2c_client *client, > > > } > > > > > >

Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

2014-05-11 Thread Jean Delvare
Hi Guenter, Josef, On Sun, 11 May 2014 15:40:21 -0700, Guenter Roeck wrote: > On 05/11/2014 06:00 AM, Josef Gajdusek wrote: > > @@ -366,14 +433,19 @@ static int emc1403_probe(struct i2c_client *client, > > } > > > > static const unsigned short emc1403_address_list[] = { > > - 0x18, 0x29, 0x4

Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

2014-05-11 Thread Guenter Roeck
On 05/11/2014 06:00 AM, Josef Gajdusek wrote: Adds support for emc1412. [ ... ] @@ -330,9 +389,9 @@ static int emc1403_detect(struct i2c_client *client, } id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG); - if (id != 0x01) + if (id != 0x01 && id != 0x04)

Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

2014-05-11 Thread Guenter Roeck
On 05/11/2014 06:00 AM, Josef Gajdusek wrote: Adds support for emc1412. It is customary to explain the difference to already supported chips and what changes were made to support the new chip(s). --- diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c index 90ec117..47a98a7 100644