Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences

2007-07-29 Thread Eugene Teo
Hi Marcel, Marcel Holtmann wrote: Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all the possible NULL dereferences. Besides hci_uart_close(), we also need to make sure that hdev is valid before calling hci_{unregister,free}_dev(). >>> I don't see any issue

Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences

2007-07-29 Thread Marcel Holtmann
Hi Eugene, > >> Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all > >> the possible NULL dereferences. Besides hci_uart_close(), we also need to > >> make sure that hdev is valid before calling hci_{unregister,free}_dev(). > > > > I don't see any issue. Without HCI_UART

Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences

2007-07-29 Thread Eugene Teo
Hi Marcel, Marcel Holtmann wrote: >> Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all >> the possible NULL dereferences. Besides hci_uart_close(), we also need to >> make sure that hdev is valid before calling hci_{unregister,free}_dev(). > > I don't see any issue. Wit

Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences

2007-07-29 Thread Marcel Holtmann
Hi Eugene, > Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all > the possible NULL dereferences. Besides hci_uart_close(), we also need to > make sure that hdev is valid before calling hci_{unregister,free}_dev(). I don't see any issue. Without HCI_UART_PROTO_SET, the h