Re: [PATCH] documentation for mm.h

2001-03-08 Thread Oliver Xymoron
On Wed, 7 Mar 2001, Rik van Riel wrote: > I've taken today to write some documentation for > include/linux/mm.h, as used in 2.4.x Mostly good. > + pgprot_t vm_page_prot; /* Access permissions of this VMA. */ But a lot of the comments are trivial = deadweight. Comments are best use

Re: Questions - Re: [PATCH] documentation for mm.h

2001-03-08 Thread Ingo Oeser
Hi, On Thu, Mar 08, 2001 at 11:39:27AM +, Anton Altaparmakov wrote: > > > >+ unsigned long index;/* Our offset within mapping. */ > > > Assuming index is in bytes (it looks like it is): > >isn't. To get the byte offset, you have to multiply it by PAGE_{CACHE_,}SIZE. > > How

Re: Questions - Re: [PATCH] documentation for mm.h

2001-03-08 Thread Rik van Riel
On Thu, 8 Mar 2001, Anton Altaparmakov wrote: > At 22:33 07/03/2001, Rik van Riel wrote: > [snip] > > typedef struct page { > >+ struct list_head list; /* ->mapping has some page lists. */ > >+ struct address_space *mapping; /* The inode (or ...) we belong to. */ > >+

Re: Questions - Re: [PATCH] documentation for mm.h

2001-03-08 Thread Rik van Riel
On Thu, 8 Mar 2001, Anton Altaparmakov wrote: > At 10:51 08/03/01, Ingo Oeser wrote: > >On Thu, Mar 08, 2001 at 10:11:50AM +, Anton Altaparmakov wrote: > > > At 22:33 07/03/2001, Rik van Riel wrote: > > * A page may belong to an inode's memory mapping. In this case, > > * page->mapping is t

Re: Questions - Re: [PATCH] documentation for mm.h

2001-03-08 Thread Anton Altaparmakov
At 10:51 08/03/01, Ingo Oeser wrote: >On Thu, Mar 08, 2001 at 10:11:50AM +, Anton Altaparmakov wrote: > > At 22:33 07/03/2001, Rik van Riel wrote: > > [snip] > > > typedef struct page { > > >+ struct list_head list; /* ->mapping has some page > lists. */ > > >+ struct ad

Re: Questions - Re: [PATCH] documentation for mm.h

2001-03-08 Thread Ingo Oeser
On Thu, Mar 08, 2001 at 10:11:50AM +, Anton Altaparmakov wrote: > At 22:33 07/03/2001, Rik van Riel wrote: > [snip] > > typedef struct page { > >+ struct list_head list; /* ->mapping has some page lists. */ > >+ struct address_space *mapping; /* The inode (or ...) we bel

Questions - Re: [PATCH] documentation for mm.h

2001-03-08 Thread Anton Altaparmakov
At 22:33 07/03/2001, Rik van Riel wrote: [snip] > typedef struct page { >+ struct list_head list; /* ->mapping has some page lists. */ >+ struct address_space *mapping; /* The inode (or ...) we belong to. */ >+ unsigned long index;/* Our offset within mappi