Re: [PATCH] devm_memremap: Fix error value when memremap failed

2016-02-05 Thread Dan Williams
On Fri, Feb 5, 2016 at 5:49 PM, Dan Williams wrote: > On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani wrote: >> devm_memremap() returns an ERR_PTR() value in case of error. >> However, it returns NULL when memremap() failed. This causes >> the caller, such as the pmem driver, to proceed and oops late

Re: [PATCH] devm_memremap: Fix error value when memremap failed

2016-02-05 Thread Dan Williams
On Fri, Feb 5, 2016 at 5:40 PM, Toshi Kani wrote: > devm_memremap() returns an ERR_PTR() value in case of error. > However, it returns NULL when memremap() failed. This causes > the caller, such as the pmem driver, to proceed and oops later. > > Change devm_memremap() to return ERR_PTR(-ENXIO) wh

Re: [PATCH] devm_memremap: Fix error value when memremap failed

2016-02-05 Thread Ross Zwisler
On Fri, Feb 05, 2016 at 06:40:27PM -0700, Toshi Kani wrote: > devm_memremap() returns an ERR_PTR() value in case of error. > However, it returns NULL when memremap() failed. This causes > the caller, such as the pmem driver, to proceed and oops later. > > Change devm_memremap() to return ERR_PTR(