Re: [PATCH] device-mapper: multipath

* Andrew Morton <[EMAIL PROTECTED]> wrote: > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > +EXPORT_SYMBOL(dm_register_path_selector); > > > +EXPORT_SYMBOL(dm_unregister_path_selector); > > > > I though we agreed to only allow GPL'ed path selectors at OSDL? > > (OSDL?) > > Yup, this

Re: [PATCH] device-mapper: multipath hardware handler for EMC

Christoph Hellwig wrote: +/* Code borrowed from dm-lsi-rdac by Mike Christie */ Any reason that module isn't submitted? I do not have access to their HW specs, and have been busy with some iscsi things so I did not have time to finish things up. I was also hoping LSI would soon figure out that the

Re: [PATCH] device-mapper: multipath hardware handler for EMC

On 2005-02-11T19:58:41, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > +/* Code borrowed from dm-lsi-rdac by Mike Christie */ > > Any reason that module isn't submitted? No idea why. > > + bio->bi_bdev = path->dev->bdev; > > + bio->bi_sector = 0; > > + bio->bi_private = path; > > + bi

Re: [PATCH] device-mapper: multipath hardware handler

Hi Alasdair, Alasdair G Kergon wrote: > +/* > + * Constructs a hardware handler object, takes custom arguments > + */ > +typedef int (*hwh_ctr_fn) (struct hw_handler *hwh, unsigned arc, char > **argv); +typedef void (*hwh_dtr_fn) (struct hw_handler *hwh); > + > +typedef void (*hwh_pg_init_fn) (str

Re: [PATCH] device-mapper: multipath

On Fri, Feb 11, 2005 at 01:36:32PM -0800, Andrew Morton wrote: > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > +EXPORT_SYMBOL(dm_register_path_selector); > > > +EXPORT_SYMBOL(dm_unregister_path_selector); > Yup, this should be _GPL. Yup - and the same applies to the other exports. Alasda

Re: [PATCH] device-mapper: multipath

On Fri, Feb 11, 2005 at 01:36:32PM -0800, Andrew Morton wrote: > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > +EXPORT_SYMBOL(dm_register_path_selector); > > > +EXPORT_SYMBOL(dm_unregister_path_selector); > > > > I though we agreed to only allow GPL'ed path selectors at OSDL? > > (OSDL

Re: [PATCH] device-mapper: multipath

Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > +EXPORT_SYMBOL(dm_register_path_selector); > > +EXPORT_SYMBOL(dm_unregister_path_selector); > > I though we agreed to only allow GPL'ed path selectors at OSDL? (OSDL?) Yup, this should be _GPL. Anything which uses these exports is a derived w

Re: [PATCH] device-mapper: multipath hardware handler for EMC

> +/* Code borrowed from dm-lsi-rdac by Mike Christie */ Any reason that module isn't submitted? > + bio->bi_bdev = path->dev->bdev; > + bio->bi_sector = 0; > + bio->bi_private = path; > + bio->bi_end_io = emc_endio; > + > + page = alloc_page(GFP_ATOMIC); > + if (!page) {

Re: [PATCH] device-mapper: multipath

> +#include "dm.h" > +#include "dm-path-selector.h" > +#include "dm-bio-list.h" > +#include "dm-bio-record.h" > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Always include private headers after public ones. > +MODULE_DESCRI

Re: [PATCH] device-mapper: multipath round-robin path selector.

> +#include "dm.h" > +#include "dm-path-selector.h" > + > +#include private after public again. Also it kinda looks to me like dm headers pull in far too much kernel headers? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]