Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

On Tue, Feb 24, 2015 at 06:41:50PM +0200, Ameen Ali wrote: > avoid out-of-bounds-read by checking count before indexing. > > Signed-off-by : Ameen Ali > --- > drivers/s390/block/dcssblk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/block/dcssblk.c b/dri

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

On Tue, Feb 24, 2015 at 8:41 AM, Ameen Ali wrote: > avoid out-of-bounds-read by checking count before indexing. > > Signed-off-by : Ameen Ali Reviewed-by: Kees Cook -Kees > --- > drivers/s390/block/dcssblk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s39

Re: [PATCH] dcssblk.c : Array index 'i' is used before limits check.

On Tue, Feb 24, 2015 at 7:57 AM, Ameen Ali wrote: > Signed-off-by : Ameen Ali Can you include some text in the commit message body explaining the meaning of the change? (For example 'avoid out-of-bounds-read by checking count before indexing' or something like that?) Reviewed-by: Kees Cook Th