Re: [PATCH] csky: Fixup calltrace panic

2020-05-22 Thread Guenter Roeck
On 5/22/20 8:28 AM, Guo Ren wrote: > Hi, > > On Thu, May 21, 2020 at 10:46 PM Guenter Roeck wrote: >>> We tested it with https://github.com/c-sky/gcc (gcc-6.3) >>> >> >> That won't work for me. You really might want to consider >> supporting upstream gcc. I'll try disabling CONFIG_STACKTRACE >> f

Re: [PATCH] csky: Fixup calltrace panic

2020-05-22 Thread Guo Ren
Hi, On Thu, May 21, 2020 at 10:46 PM Guenter Roeck wrote: > > We tested it with https://github.com/c-sky/gcc (gcc-6.3) > > > > That won't work for me. You really might want to consider > supporting upstream gcc. I'll try disabling CONFIG_STACKTRACE > for csky build tests. If that doesn't work, I

Re: [PATCH] csky: Fixup calltrace panic

2020-05-21 Thread Guenter Roeck
On 5/20/20 12:50 AM, Guo Ren wrote: > Hi Guenter, > >> 在 2020年5月18日，上午1:52，Guenter Roeck 写道： >> >> Hi, >> >> On Wed, May 13, 2020 at 03:15:25PM +0800, Guo Ren wrote: >>> The implementation of show_stack will panic with wrong fp: >>> >>> addr= *fp++; >>> >>> because the fp isn't checked proper

Re: [PATCH] csky: Fixup calltrace panic

2020-05-20 Thread Guo Ren
Hi Guenter, > 在 2020年5月18日，上午1:52，Guenter Roeck 写道： > > Hi, > > On Wed, May 13, 2020 at 03:15:25PM +0800, Guo Ren wrote: >> The implementation of show_stack will panic with wrong fp: >> >> addr= *fp++; >> >> because the fp isn't checked properly. >> >> The current implementations of show

Re: [PATCH] csky: Fixup calltrace panic

2020-05-17 Thread Guenter Roeck
Hi, On Wed, May 13, 2020 at 03:15:25PM +0800, Guo Ren wrote: > The implementation of show_stack will panic with wrong fp: > > addr= *fp++; > > because the fp isn't checked properly. > > The current implementations of show_stack, wchan and stack_trace > haven't been designed properly, so jus