Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread David Rientjes
On Fri, 24 Jan 2014, Tejun Heo wrote: > > Nobody is depending on shit, the patch is removing a completely pointless > > memory allocation in braindead cpuset code. What you think is "harmful" > > or "more harmful" is irrelevant, but nobody said anything about depending > > on that behavior to

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread Tejun Heo
Hey, On Fri, Jan 24, 2014 at 02:51:12AM -0800, David Rientjes wrote: > Nobody is depending on shit, the patch is removing a completely pointless > memory allocation in braindead cpuset code. What you think is "harmful" > or "more harmful" is irrelevant, but nobody said anything about depending

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread David Rientjes
On Fri, 24 Jan 2014, Tejun Heo wrote: > > It's not harmless, if heap_init() fails with -ENOMEM then the write fails > > even though it may not be for memory_spread_page or memory_spread_slab, > > which is the minority of the callers of this function. > > And depending on details like that would

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread Tejun Heo
On Fri, Jan 24, 2014 at 04:03:18PM +0530, Viresh Kumar wrote: > On 24 January 2014 15:57, Tejun Heo wrote: > > Ummm... so, the original posting forgot to cc Li (the maintainer), me > > or cgroups mailing list. Please don't do this in the future. > > I thought Ingo/PeterZ are maintainers of this

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread Tejun Heo
On Fri, Jan 24, 2014 at 02:33:27AM -0800, David Rientjes wrote: > It's not harmless, if heap_init() fails with -ENOMEM then the write fails > even though it may not be for memory_spread_page or memory_spread_slab, > which is the minority of the callers of this function. And depending on details

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread David Rientjes
On Fri, 24 Jan 2014, Li Zefan wrote: > >> update_flag() routine uses heap only when spread_flag_changed is true. > >> Otherwise > >> heap isn't used, but is allocated and freed unnecessarily. > >> > > but harmless > It's not harmless, if heap_init() fails with -ENOMEM then the write fails eve

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread Viresh Kumar
On 24 January 2014 15:57, Tejun Heo wrote: > Ummm... so, the original posting forgot to cc Li (the maintainer), me > or cgroups mailing list. Please don't do this in the future. I thought Ingo/PeterZ are maintainers of this as well, just after sending patch I had a look at MAINTAINERS to see if

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-24 Thread Tejun Heo
On Fri, Jan 24, 2014 at 10:27:34AM +0530, Viresh Kumar wrote: > On 24 January 2014 07:28, Li Zefan wrote: > >> Acked-by: David Rientjes > > > > Acked-by: Li Zefan > > Thanks.. > > > I would like this patch be picked up by Tejun. I'll send out a patchset > > for cpuset which may have conflictio

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-23 Thread Viresh Kumar
On 24 January 2014 07:28, Li Zefan wrote: >> Acked-by: David Rientjes > > Acked-by: Li Zefan Thanks.. > I would like this patch be picked up by Tejun. I'll send out a patchset > for cpuset which may have confliction with this one. Its already applied by Andrew Morton.. -- To unsubscribe from

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-23 Thread Li Zefan
Cc: Tejun On 2014/1/24 5:31, David Rientjes wrote: > On Thu, 23 Jan 2014, Viresh Kumar wrote: > >> update_flag() routine uses heap only when spread_flag_changed is true. >> Otherwise >> heap isn't used, but is allocated and freed unnecessarily. >> but harmless >> Fix this by allocating heap on

Re: [PATCH] cpusets: Allocate heap only when required

2014-01-23 Thread David Rientjes
On Thu, 23 Jan 2014, Viresh Kumar wrote: > update_flag() routine uses heap only when spread_flag_changed is true. > Otherwise > heap isn't used, but is allocated and freed unnecessarily. > > Fix this by allocating heap only when required. > > Signed-off-by: Viresh Kumar Acked-by: David Rientj