Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Feng Xiao
I get it, thanks. 在 2016/3/21 23:52, Heiko Stübner 写道: Am Montag, 21. März 2016, 16:13:40 schrieb Heiko Stübner: Hi, Am Montag, 21. März 2016, 21:24:32 schrieb Feng Xiao: 在 2016/3/21 17:58, Viresh Kumar 写道: On 21-03-16, 10:54, Heiko Stübner wrote: I hadn't seen that yet ... nice that cpufre

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Heiko Stübner
Am Montag, 21. März 2016, 16:13:40 schrieb Heiko Stübner: > Hi, > > Am Montag, 21. März 2016, 21:24:32 schrieb Feng Xiao: > > 在 2016/3/21 17:58, Viresh Kumar 写道: > > > On 21-03-16, 10:54, Heiko Stübner wrote: > > >> I hadn't seen that yet ... nice that cpufreq-dt now also supports > > >> clusters

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Heiko Stübner
Hi, Am Montag, 21. März 2016, 21:24:32 schrieb Feng Xiao: > 在 2016/3/21 17:58, Viresh Kumar 写道: > > On 21-03-16, 10:54, Heiko Stübner wrote: > >> I hadn't seen that yet ... nice that cpufreq-dt now also supports > >> clusters :-) > >> > >> The other part still stands though, as we probably should

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Viresh Kumar
On 21-03-16, 21:24, Feng Xiao wrote: > Rockchip-cpufreq.c depends on ARM_ROCKCHIP_CPUFREQ, it will not be compiled > on non-Rockchip platforms. > The driver can support all Rockchip SoCs up to now, add > of_machine_is_compatible may be redundant ? Heard of Multi-platform kernels ? -- viresh

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Feng Xiao
在 2016/3/21 17:58, Viresh Kumar 写道: On 21-03-16, 10:54, Heiko Stübner wrote: I hadn't seen that yet ... nice that cpufreq-dt now also supports clusters :-) The other part still stands though, as we probably should register the platform-device somewhere else and not in some new special module.

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Viresh Kumar
On 21-03-16, 10:54, Heiko Stübner wrote: > I hadn't seen that yet ... nice that cpufreq-dt now also supports clusters :-) > > The other part still stands though, as we probably should register the > platform-device somewhere else and not in some new special module. > > When everything is using c

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Heiko Stübner
Am Montag, 21. März 2016, 15:20:49 schrieb Viresh Kumar: > On 18-03-16, 13:56, Heiko Stübner wrote: > > Also, on both the rk3368 as well as the rk3399, you probably want the > > cluster- handling of arm-bL-cpufreq-dt. > > Contrary to its name it is _not_ limited to switching between clusters, > > b

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-21 Thread Viresh Kumar
On 18-03-16, 13:56, Heiko Stübner wrote: > Also, on both the rk3368 as well as the rk3399, you probably want the cluster- > handling of arm-bL-cpufreq-dt. > Contrary to its name it is _not_ limited to switching between clusters, but > can also control frequencies of multiple cpu-clusters running a

Re: [PATCH] cpufreq: rockchip: add driver

2016-03-19 Thread Heiko Stübner
Hi Feng, Am Freitag, 18. März 2016, 20:10:04 schrieb Feng Xiao: > This driver will directly use cpufreq-dt driver as backend. > > As there is not a generic devicetree board file(rockchip.c) > on ARM64 architecture, so remove platform_device_register_simple > in rockchip.c and add a new cpufreq dr