Re: [PATCH] connector: improved unaligned access error fix

2013-11-14 Thread David Miller
From: Chris Metcalf Date: Thu, 14 Nov 2013 12:09:21 -0500 > In af3e095a1fb4, Erik Jacobsen fixed one type of unaligned access > bug for ia64 by converting a 64-bit write to use put_unaligned(). > Unfortunately, since gcc will convert a short memset() to a series > of appropriately-aligned stores,

Re: [PATCH] connector: improved unaligned access error fix

2013-11-14 Thread Chris Metcalf
On 11/14/2013 2:45 PM, Pete Zaitcev wrote: > On Thu, 14 Nov 2013 12:09:21 -0500 > Chris Metcalf wrote: > >> -__u8 buffer[CN_PROC_MSG_SIZE]; >> +__u8 buffer[CN_PROC_MSG_SIZE] __aligned(8); >> -msg = (struct cn_msg *)buffer; >> +msg = buffer_to_cn_msg(buffer); >> ev = (struct pr

Re: [PATCH] connector: improved unaligned access error fix

2013-11-14 Thread Pete Zaitcev
On Thu, 14 Nov 2013 12:09:21 -0500 Chris Metcalf wrote: > - __u8 buffer[CN_PROC_MSG_SIZE]; > + __u8 buffer[CN_PROC_MSG_SIZE] __aligned(8); > - msg = (struct cn_msg *)buffer; > + msg = buffer_to_cn_msg(buffer); > ev = (struct proc_event *)msg->data; > memset(&ev->event