Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Julia Lawall
On Sat, 26 Dec 2015, Sergei Shtylyov wrote: > On 12/26/2015 11:24 PM, Julia Lawall wrote: > > > The conclusion seems to be that it is useful to override the value, so we > > can just drop this semantic patch. > >No! As I said, unconditionally overriding an error value breaks the > deferred

Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Sergei Shtylyov
On 12/26/2015 11:24 PM, Julia Lawall wrote: The conclusion seems to be that it is useful to override the value, so we can just drop this semantic patch. No! As I said, unconditionally overriding an error value breaks the deferred probing. It's actually a bug to override it, so the patch se

Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Julia Lawall
The conclusion seems to be that it is useful to override the value, so we can just drop this semantic patch. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Julia Lawall
On Sat, 26 Dec 2015, Sergei Shtylyov wrote: > On 12/26/2015 10:24 PM, Julia Lawall wrote: > > > The error return value of platform_get_irq seems to often get dropped. > >Maybe it was intentional (see my recent follow-up to your netdev patch). > But if an error gets unconditionally overriden,

Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Sergei Shtylyov
On 12/26/2015 10:24 PM, Julia Lawall wrote: The error return value of platform_get_irq seems to often get dropped. Maybe it was intentional (see my recent follow-up to your netdev patch). But if an error gets unconditionally overriden, deferred probing can't work. So your patches seem goo