Re: Re: [PATCH] clk/meson: fixes memleak issue in init err branch

2020-05-02 Thread Martin Blumenstingl
Hi Bernhard, On Thu, Apr 30, 2020 at 5:33 AM 赵军奎 wrote: [...] > I am not sure whether my understanding is correct. > I feels that the failure of our module can not block the entire kernel from > starting. > Maybe we should throw an exception, clear the status, as "old way", > and continue to exe

Re: [PATCH] clk/meson: fixes memleak issue in init err branch

2020-04-29 Thread Martin Blumenstingl
Hi Jerome, On Wed, Apr 29, 2020 at 2:37 PM Jerome Brunet wrote: > > > On Wed 29 Apr 2020 at 05:14, Bernard Zhao wrote: > > > In common init function, when run into err branch, we didn`t > > use kfree to release kzmalloc area, this may bring in memleak > > Thx for reporting this Bernard. > I'm no

Re: [PATCH] clk/meson: fixes memleak issue in init err branch

2020-04-29 Thread Jerome Brunet
On Wed 29 Apr 2020 at 05:14, Bernard Zhao wrote: > In common init function, when run into err branch, we didn`t > use kfree to release kzmalloc area, this may bring in memleak Thx for reporting this Bernard. I'm not a fan of adding kfree everywhere. I'd much prefer a label and clear error exit