Re: [PATCH] clean up FIXME in do_timer_interrupt-lock fix

2005-03-19 Thread George Anzinger
Andrew Morton wrote: George Anzinger wrote: Did you pick this up? First sent on 3-11. I did, although now looking at it I have issues. I was not happy with the locking on this. Two changes: 1) Turn off irq while setting the clock. 2) Call the timer code only through the timer interface (se

Re: [PATCH] clean up FIXME in do_timer_interrupt-lock fix

2005-03-19 Thread Andrew Morton
George Anzinger wrote: > > Did you pick this up? First sent on 3-11. I did, although now looking at it I have issues. > I was not happy with the locking on this. Two changes: > 1) Turn off irq while setting the clock. > 2) Call the timer code only through the timer interface > (set a s

Re: [PATCH] clean up FIXME in do_timer_interrupt-lock fix

2005-03-19 Thread George Anzinger
Did you pick this up? First sent on 3-11. Andrew Morton wrote: Lee Revell <[EMAIL PROTECTED]> wrote: On Thu, 2005-03-10 at 00:42 -0800, George Anzinger wrote: This patch changes the update of the cmos clock to be timer driven rather than poll driven by the timer interrupt function. If the clock i