Re: [PATCH] clean up FIXME in do_timer_interrupt-lock fix

2005-03-19 Thread George Anzinger
Andrew Morton wrote: George Anzinger wrote: Did you pick this up? First sent on 3-11. I did, although now looking at it I have issues. I was not happy with the locking on this. Two changes: 1) Turn off irq while setting the clock. 2) Call the timer code only through the timer interface (se

Re: [PATCH] clean up FIXME in do_timer_interrupt-lock fix

2005-03-19 Thread Andrew Morton
George Anzinger wrote: > > Did you pick this up? First sent on 3-11. I did, although now looking at it I have issues. > I was not happy with the locking on this. Two changes: > 1) Turn off irq while setting the clock. > 2) Call the timer code only through the timer interface > (set a s

Re: [PATCH] clean up FIXME in do_timer_interrupt-lock fix

2005-03-19 Thread George Anzinger
Did you pick this up? First sent on 3-11. Andrew Morton wrote: Lee Revell <[EMAIL PROTECTED]> wrote: On Thu, 2005-03-10 at 00:42 -0800, George Anzinger wrote: This patch changes the update of the cmos clock to be timer driven rather than poll driven by the timer interrupt function. If the clock i

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-11 Thread George Anzinger
Andrew Morton wrote: Lee Revell <[EMAIL PROTECTED]> wrote: On Thu, 2005-03-10 at 00:42 -0800, George Anzinger wrote: This patch changes the update of the cmos clock to be timer driven rather than poll driven by the timer interrupt function. If the clock is not being synced to an outside source the

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-11 Thread Andrew Morton
Lee Revell <[EMAIL PROTECTED]> wrote: > > On Thu, 2005-03-10 at 00:42 -0800, George Anzinger wrote: > > This patch changes the update of the cmos clock to be timer driven > > rather than poll driven by the timer interrupt function. If the clock > > is not being synced to an outside source the time

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-11 Thread Lee Revell
On Thu, 2005-03-10 at 00:42 -0800, George Anzinger wrote: > This patch changes the update of the cmos clock to be timer driven > rather than poll driven by the timer interrupt function. If the clock > is not being synced to an outside source the timer is removed and thus > system overhead is nill

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-10 Thread George Anzinger
Ok, here is a patch. See what you think. This patch assumes that Lee's patch has been merged (although it eliminates all of it). George George Anzinger wrote: Lee Revell wrote: On Fri, 2005-03-04 at 12:58 -0800, George Anzinger wrote: Lee Revell wrote: On Fri, 2005-03-04 at 02:28 -0800, George

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-08 Thread George Anzinger
Lee Revell wrote: On Fri, 2005-03-04 at 12:58 -0800, George Anzinger wrote: Lee Revell wrote: On Fri, 2005-03-04 at 02:28 -0800, George Anzinger wrote: The thing that brought this code to my attention is that with PREEMPT_RT this happens to be the longest non-preemptible code path in the kernel. On

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-08 Thread Lee Revell
On Fri, 2005-03-04 at 12:58 -0800, George Anzinger wrote: > Lee Revell wrote: > > On Fri, 2005-03-04 at 02:28 -0800, George Anzinger wrote: > > The thing that brought this code to my attention is that with PREEMPT_RT > > this happens to be the longest non-preemptible code path in the kernel. > > On

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-04 Thread George Anzinger
Lee Revell wrote: On Fri, 2005-03-04 at 02:28 -0800, George Anzinger wrote: Lee Revell wrote: On Thu, 2005-03-03 at 16:45 -0800, Andrew Morton wrote: If efi_enabled is true and efi_set_rtc_mmss(xtime.tv_sec) returns zero, the new code will run set_rtc_mmss(xtime.tv_sec) whereas the old code won't.

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-04 Thread Lee Revell
On Fri, 2005-03-04 at 02:28 -0800, George Anzinger wrote: > Lee Revell wrote: > > On Thu, 2005-03-03 at 16:45 -0800, Andrew Morton wrote: > > > >>If efi_enabled is true and efi_set_rtc_mmss(xtime.tv_sec) returns zero, the > >>new code will run set_rtc_mmss(xtime.tv_sec) whereas the old code won't.

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-04 Thread George Anzinger
Lee Revell wrote: On Thu, 2005-03-03 at 16:45 -0800, Andrew Morton wrote: If efi_enabled is true and efi_set_rtc_mmss(xtime.tv_sec) returns zero, the new code will run set_rtc_mmss(xtime.tv_sec) whereas the old code won't. Argh, I should know better then to send patches before having coffee. Here'

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-03 Thread Lee Revell
On Thu, 2005-03-03 at 16:45 -0800, Andrew Morton wrote: > If efi_enabled is true and efi_set_rtc_mmss(xtime.tv_sec) returns zero, the > new code will run set_rtc_mmss(xtime.tv_sec) whereas the old code won't. Argh, I should know better then to send patches before having coffee. Here's a new patch

Re: [PATCH] clean up FIXME in do_timer_interrupt

2005-03-03 Thread Andrew Morton
Lee Revell <[EMAIL PROTECTED]> wrote: > > AFAICT this code is equivalent and cleans up the (efi_)set_rtc_mmss code > referred to as "horrible... FIXME" in the comments. Completely > untested. > > Signed-Off-By: Lee Revell <[EMAIL PROTECTED]> > > --- linux-2.6.11-rc4/arch/i386/kernel/time.c.orig