Re: [PATCH] checkpatch: make the line length warnings match the coding style document

2020-12-23 Thread Christoph Hellwig
On Tue, Dec 22, 2020 at 08:22:06AM -0800, Joe Perches wrote: > Having checkpatch complain about > 80 column lines didn't stop > patches before, likely it wouldn't stop patches now. > > Emitting yet more messages for trivial lines > 80 columns is also > against the intent of the commit that changed

Re: [PATCH] checkpatch: make the line length warnings match the coding style document

2020-12-22 Thread Joe Perches
On Tue, 2020-12-22 at 14:12 +0100, Christoph Hellwig wrote: > On Mon, Dec 21, 2020 at 08:08:20PM -0800, Joe Perches wrote: > > On Thu, 2020-12-10 at 13:27 -0800, Joe Perches wrote: > > > On Thu, 2020-12-10 at 20:09 +, Matthew Wilcox wrote: > > > > On Thu, Dec 10, 2020 at 12:05:04PM -0800, Joe P

Re: [PATCH] checkpatch: make the line length warnings match the coding style document

2020-12-22 Thread Christoph Hellwig
On Mon, Dec 21, 2020 at 08:08:20PM -0800, Joe Perches wrote: > On Thu, 2020-12-10 at 13:27 -0800, Joe Perches wrote: > > On Thu, 2020-12-10 at 20:09 +, Matthew Wilcox wrote: > > > On Thu, Dec 10, 2020 at 12:05:04PM -0800, Joe Perches wrote: > > > > Also, given the ever increasing average identi

Re: [PATCH] checkpatch: make the line length warnings match the coding style document

2020-12-21 Thread Joe Perches
On Thu, 2020-12-10 at 13:27 -0800, Joe Perches wrote: > On Thu, 2020-12-10 at 20:09 +, Matthew Wilcox wrote: > > On Thu, Dec 10, 2020 at 12:05:04PM -0800, Joe Perches wrote: > > > Also, given the ever increasing average identifier length, strict > > > adherence to 80 columns is sometimes just n

Re: [PATCH] checkpatch: make the line length warnings match the coding style document

2020-12-10 Thread Joe Perches
On Thu, 2020-12-10 at 20:09 +, Matthew Wilcox wrote: > On Thu, Dec 10, 2020 at 12:05:04PM -0800, Joe Perches wrote: > > Also, given the ever increasing average identifier length, strict > > adherence to 80 columns is sometimes just not possible without silly > > visual gymnastics. The kernel n

Re: [PATCH] checkpatch: make the line length warnings match the coding style document

2020-12-10 Thread Matthew Wilcox
On Thu, Dec 10, 2020 at 12:05:04PM -0800, Joe Perches wrote: > Also, given the ever increasing average identifier length, strict > adherence to 80 columns is sometimes just not possible without silly > visual gymnastics. The kernel now has quite a lot of 30+ character > length function names, cons

Re: [PATCH] checkpatch: make the line length warnings match the coding style document

2020-12-10 Thread Joe Perches
On Thu, 2020-12-10 at 09:22 +0100, Christoph Hellwig wrote: > Add a new informational message that lines <= 80 chars are still > preffered. Without this people unfortunately auto format code way over > 80 lines without the required benefit for readability. In general, I agree with some of the con